CSSGroupingRule several fixes to throw the correct error

rbri · rbri · commit a1219fa03bd0 · 2025-02-02T14:48:29.000+01:00
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,9 @@
 
     <body>
         <release version="4.10.0" date="February xx, 2025" description="Bugfixes">
+            <action type="fix" dev="rbri">
+                CSSGroupingRule several fixes to throw the correct error.
+            </action>
             <action type="fix" dev="rbri">
                 HTMLInputElement value/selectionStart/selectionEnd properties throws the correct error (InvalidStateError).
             </action>
diff --git a/src/main/java/org/htmlunit/javascript/host/css/CSSGroupingRule.java b/src/main/java/org/htmlunit/javascript/host/css/CSSGroupingRule.java
@@ -114,10 +114,14 @@ else if (JavaScriptEngine.isUndefined(position)) {
                     return positionInt;
                 }
                 catch (final DOMException ex) {
-                    throw JavaScriptEngine.throwAsScriptRuntimeEx(ex);
+                    throw JavaScriptEngine.asJavaScriptException(
+                            getWindow(),
+                            new org.htmlunit.javascript.host.dom.DOMException(
+                                    ex.getMessage(),
+                                    ex.code));
                 }
             }
-            throw JavaScriptEngine.throwAsScriptRuntimeEx(e);
+            throw JavaScriptEngine.syntaxError(e.getMessage());
         }
     }
 
@@ -133,7 +137,11 @@ public void deleteRule(final int position) {
             refreshCssRules();
         }
         catch (final DOMException e) {
-            throw JavaScriptEngine.throwAsScriptRuntimeEx(e);
+            throw JavaScriptEngine.asJavaScriptException(
+                    getWindow(),
+                    new org.htmlunit.javascript.host.dom.DOMException(
+                            e.getMessage(),
+                            e.code));
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -114,10 +114,14 @@ else if (JavaScriptEngine.isUndefined(position)) {`
`114`	`114`	`return positionInt;`
`115`	`115`	`}`
`116`	`116`	`catch (final DOMException ex) {`
`117`		`- throw JavaScriptEngine.throwAsScriptRuntimeEx(ex);`
	`117`	`+ throw JavaScriptEngine.asJavaScriptException(`
	`118`	`+ getWindow(),`
	`119`	`+ new org.htmlunit.javascript.host.dom.DOMException(`
	`120`	`+ ex.getMessage(),`
	`121`	`+ ex.code));`
`118`	`122`	`}`
`119`	`123`	`}`
`120`		`- throw JavaScriptEngine.throwAsScriptRuntimeEx(e);`
	`124`	`+ throw JavaScriptEngine.syntaxError(e.getMessage());`
`121`	`125`	`}`
`122`	`126`	`}`
`123`	`127`
`@@ -133,7 +137,11 @@ public void deleteRule(final int position) {`
`133`	`137`	`refreshCssRules();`
`134`	`138`	`}`
`135`	`139`	`catch (final DOMException e) {`
`136`		`- throw JavaScriptEngine.throwAsScriptRuntimeEx(e);`
	`140`	`+ throw JavaScriptEngine.asJavaScriptException(`
	`141`	`+ getWindow(),`
	`142`	`+ new org.htmlunit.javascript.host.dom.DOMException(`
	`143`	`+ e.getMessage(),`
	`144`	`+ e.code));`
`137`	`145`	`}`
`138`	`146`	`}`
`139`	`147`