get rid of NotYetImplemented

rbri · rbri · commit a7154f2f1341 · 2025-05-19T19:48:52.000+02:00
diff --git a/src/test/java/org/htmlunit/javascript/RhinoTest.java b/src/test/java/org/htmlunit/javascript/RhinoTest.java
@@ -17,7 +17,7 @@
 import org.htmlunit.WebDriverTestCase;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.annotation.Alerts;
-import org.htmlunit.junit.annotation.NotYetImplemented;
+import org.htmlunit.junit.annotation.HtmlUnitNYI;
 import org.htmlunit.util.MimeType;
 import org.junit.Test;
 import org.junit.runner.RunWith;
@@ -38,7 +38,10 @@ public class RhinoTest extends WebDriverTestCase {
      */
     @Test
     @Alerts({"true", "true"})
-    @NotYetImplemented
+    @HtmlUnitNYI(CHROME = {"false", "false"},
+            EDGE = {"false", "false"},
+            FF = {"false", "false"},
+            FF_ESR = {"false", "false"})
     public void isStrict_GlobalThis() throws Exception {
         final String html = DOCTYPE_HTML
             + "<html>\n"
@@ -63,7 +66,10 @@ public void isStrict_GlobalThis() throws Exception {
      */
     @Test
     @Alerts("true")
-    @NotYetImplemented
+    @HtmlUnitNYI(CHROME = "false",
+            EDGE = "false",
+            FF = "false",
+            FF_ESR = "false")
     public void isStrict_evalVar() throws Exception {
         final String html = DOCTYPE_HTML
             + "<html>\n"
diff --git a/src/test/java/org/htmlunit/javascript/ScriptableObjectTest.java b/src/test/java/org/htmlunit/javascript/ScriptableObjectTest.java
@@ -18,9 +18,9 @@
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.annotation.Alerts;
 import org.htmlunit.junit.annotation.HtmlUnitNYI;
-import org.htmlunit.junit.annotation.NotYetImplemented;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.openqa.selenium.WebDriverException;
 
 /**
  * Tests for general scriptable objects in the browser context.
@@ -137,7 +137,10 @@ public void ctorNotChangeableForPrimitives() throws Exception {
      */
     @Test
     @Alerts({"TypeError", "true", "true"})
-    @NotYetImplemented
+    @HtmlUnitNYI(CHROME = "org.htmlunit.ScriptException: TypeError: Cannot set property \"constructor\" of abc",
+            EDGE = "org.htmlunit.ScriptException: TypeError: Cannot set property \"constructor\" of abc",
+            FF = "org.htmlunit.ScriptException: TypeError: Cannot set property \"constructor\" of abc",
+            FF_ESR = "org.htmlunit.ScriptException: TypeError: Cannot set property \"constructor\" of abc")
     public void ctorNotChangeableForPrimitivesStrict() throws Exception {
         final String html = DOCTYPE_HTML
                 + "<html><body>\n"
@@ -165,7 +168,12 @@ public void ctorNotChangeableForPrimitivesStrict() throws Exception {
                 + "</body>\n"
                 + "</html>\n";
 
-        loadPageVerifyTitle2(html);
+        try {
+            loadPageVerifyTitle2(html);
+        }
+        catch (final WebDriverException e) {
+            assertTrue(e.getMessage(), e.getMessage().startsWith(getExpectedAlerts()[0]));
+        }
     }
 
     /**
diff --git a/src/test/java/org/htmlunit/javascript/host/Window3Test.java b/src/test/java/org/htmlunit/javascript/host/Window3Test.java
@@ -29,7 +29,7 @@
 import org.htmlunit.WebDriverTestCase;
 import org.htmlunit.junit.BrowserRunner;
 import org.htmlunit.junit.annotation.Alerts;
-import org.htmlunit.junit.annotation.NotYetImplemented;
+import org.htmlunit.junit.annotation.HtmlUnitNYI;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.openqa.selenium.By;
@@ -1888,7 +1888,34 @@ public void onload() throws Exception {
              "window at load",
              "window at load capture",
              "body onload"})
-    @NotYetImplemented
+    @HtmlUnitNYI(CHROME = {"element 1 onload",
+                           "element 2 onerror",
+                           "document DOMContentLoaded",
+                           "window DOMContentLoaded",
+                           "window at load",
+                           "window at load capture",
+                           "body onload"},
+            EDGE = {"element 1 onload",
+                    "element 2 onerror",
+                    "document DOMContentLoaded",
+                    "window DOMContentLoaded",
+                    "window at load",
+                    "window at load capture",
+                    "body onload"},
+            FF = {"element 1 onload",
+                  "element 2 onerror",
+                  "document DOMContentLoaded",
+                  "window DOMContentLoaded",
+                  "window at load",
+                  "window at load capture",
+                  "body onload"},
+            FF_ESR = {"element 1 onload",
+                      "element 2 onerror",
+                      "document DOMContentLoaded",
+                      "window DOMContentLoaded",
+                      "window at load",
+                      "window at load capture",
+                      "body onload"})
     public void onloadScript() throws Exception {
         getMockWebConnection().setResponse(URL_SECOND, "");
 
