Skip to content

Commit d72d7d7

Browse files
committed
get rid of NotYetImplemented
1 parent 2c818aa commit d72d7d7

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

src/test/java/org/htmlunit/libraries/TinyMceTest.java

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import org.htmlunit.WebDriverTestCase;
2121
import org.htmlunit.junit.BrowserRunner;
2222
import org.htmlunit.junit.annotation.Alerts;
23-
import org.htmlunit.junit.annotation.NotYetImplemented;
23+
import org.htmlunit.junit.annotation.HtmlUnitNYI;
2424
import org.junit.Before;
2525
import org.junit.Test;
2626
import org.junit.runner.RunWith;
@@ -57,7 +57,10 @@ public void api() throws Exception {
5757
@Alerts(DEFAULT = {"89", "0"},
5858
CHROME = {"89", "1"},
5959
EDGE = {"89", "1"})
60-
@NotYetImplemented
60+
@HtmlUnitNYI(CHROME = {"70", "50"},
61+
EDGE = {"70", "50"},
62+
FF = {"70", "50"},
63+
FF_ESR = {"70", "50"})
6164
public void basic() throws Exception {
6265
test("basic", Integer.parseInt(getExpectedAlerts()[0]), Integer.parseInt(getExpectedAlerts()[1]));
6366
}
@@ -86,7 +89,7 @@ private void test(final String fileName, final int expectedTotal, final int expe
8689

8790
final WebElement failedSpan = result.findElement(By.xpath("./span[@class='bad']"));
8891
final int failed = Integer.parseInt(failedSpan.getText());
89-
assertEquals(msg.toString(), expectedFailed, failed);
92+
assertEquals(expectedFailed, failed);
9093
}
9194

9295
/**

src/test/java/org/htmlunit/libraries/YuiTest.java

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.htmlunit.WebDriverTestCase;
2727
import org.htmlunit.junit.BrowserRunner;
2828
import org.htmlunit.junit.annotation.Alerts;
29+
import org.htmlunit.junit.annotation.HtmlUnitNYI;
2930
import org.htmlunit.junit.annotation.NotYetImplemented;
3031
import org.junit.Before;
3132
import org.junit.Ignore;
@@ -153,7 +154,16 @@ public void dataTable() throws Exception {
153154
"test_createlink", "test_selected_element", "test_dom_path"},
154155
FF = "test_createlink",
155156
FF_ESR = "test_createlink")
156-
@NotYetImplemented
157+
@HtmlUnitNYI(CHROME = {"test_blank_image", "test_insertimage", "test_image_props",
158+
"test_close_window", "test_bold", "test_selected_element",
159+
"test_dom_path", "test_createlink"},
160+
EDGE = {"test_blank_image", "test_insertimage", "test_image_props",
161+
"test_close_window", "test_bold", "test_selected_element",
162+
"test_dom_path", "test_createlink"},
163+
FF = {"test_blank_image", "test_insertimage", "test_image_props",
164+
"test_bold", "test_createlink", "test_hidden_elements"},
165+
FF_ESR = {"test_blank_image", "test_insertimage", "test_image_props",
166+
"test_bold", "test_createlink", "test_hidden_elements"})
157167
public void editor() throws Exception {
158168
doTest("editor.html", Arrays.asList(getExpectedAlerts()));
159169
}

0 commit comments

Comments
 (0)