use maven-model pom parser

Author: rbri

pom.xml

@@ -67,6 +67,7 @@
         <image-comparison.version>4.4.0</image-comparison.version>
         <imageio-batik.version>3.13.0</imageio-batik.version>
         <jfreechart.version>1.5.6</jfreechart.version>
+        <maven-model.version>3.9.12</maven-model.version>
 
         <!-- quality -->
         <checkstyle.version>12.3.1</checkstyle.version>
@@ -1552,6 +1553,11 @@
             <version>${jfreechart.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.maven</groupId>
+            <artifactId>maven-model</artifactId>
+            <version>${maven-model.version}</version>
+        </dependency>
         <!-- Jetty -->
         <dependency>
             <groupId>org.eclipse.jetty</groupId>

src/test/java/org/htmlunit/ExternalTest.java

@@ -17,6 +17,8 @@
 import static java.nio.charset.StandardCharsets.ISO_8859_1;
 
 import java.io.File;
+import java.io.FileReader;
+import java.io.IOException;
 import java.net.UnknownHostException;
 import java.text.DateFormat;
 import java.text.SimpleDateFormat;
@@ -31,6 +33,8 @@
 
 import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.model.Model;
+import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
 import org.htmlunit.html.DomNode;
 import org.htmlunit.html.DomNodeList;
 import org.htmlunit.html.HtmlAnchor;
@@ -75,62 +79,37 @@ public void testEnvironment() throws Exception {
     /**
      * Tests that POM dependencies are the latest.
      *
-     * Currently it is configured to check every week.
+     * Currently, it is configured to check every week.
      *
      * @throws Exception if an error occurs
      */
     @Test
     public void pom() throws Exception {
-        final Map<String, String> properties = new HashMap<>();
-        final List<String> lines = FileUtils.readLines(new File("pom.xml"), ISO_8859_1);
+        final File pomFile = new File("pom.xml");
+        if (!pomFile.exists()) {
+            throw new IOException("POM file not found: " + pomFile.getAbsolutePath());
+        }
 
-        final List<String> wrongVersions = new LinkedList<>();
-        boolean inComment = false;
-        for (int i = 0; i < lines.size(); i++) {
-            String line = lines.get(i);
-
-            String cleaned = "";
-            if (!inComment) {
-                final int startIdx = line.indexOf("<!--");
-                if (startIdx != -1) {
-                    cleaned += line.substring(0, startIdx);
-                    inComment = true;
+        MavenXpp3Reader reader = new MavenXpp3Reader();
+        try (FileReader fileReader = new FileReader(pomFile)) {
+            final Model model = reader.read(fileReader);
+
+            final List<String> wrongVersions = new LinkedList<>();
+            for (var dep : model.getDependencies()) {
+                String version = dep.getVersion();
+                if (version.startsWith("${")) {
+                    version = "" + model.getProperties().get(version.substring(2, version.length() - 1));
                 }
-            }
-            if (inComment) {
-                final int endIdx = line.indexOf("-->");
-                if (endIdx != -1) {
-                    cleaned += line.substring(endIdx + 3);
-                    inComment = false;
+                try {
+                    assertVersion(dep.getGroupId(), dep.getArtifactId(), version);
                 }
-                line = cleaned;
-            }
-
-            if (line.trim().equals("<properties>")) {
-                processProperties(lines, i + 1, properties);
-            }
-            if (line.contains("artifactId")
-                    && !line.contains(">htmlunit<")
-                    && !line.contains(">selenium-devtools-v")) {
-                final String artifactId = getValue(line);
-                final String groupId = getValue(lines.get(i - 1));
-                if (!lines.get(i + 1).contains("</exclusion>")) {
-                    String version = getValue(lines.get(i + 1));
-                    if (version.startsWith("${")) {
-                        version = properties.get(version.substring(2, version.length() - 1));
-                    }
-                    try {
-                        assertVersion(groupId, artifactId, version);
-                    }
-                    catch (final AssertionError e) {
-                        wrongVersions.add(e.getMessage());
-                    }
+                catch (final AssertionError e) {
+                    wrongVersions.add(e.getMessage());
                 }
             }
-        }
-
-        if (!wrongVersions.isEmpty()) {
-            Assertions.fail(String.join("\n ", wrongVersions));
+            if (!wrongVersions.isEmpty()) {
+                Assertions.fail(String.join("\n ", wrongVersions));
+            }
         }
 
         assertVersion("org.sonatype.oss", "oss-parent", "9");