Replace deprecated punycode

[eeeggg]

Hello @ksvirkou-hubspot

Using Node.js lts/jod:

(node:3690961) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
(Use `node --trace-deprecation ...` to show where the warning was created)

The punycode module was deprecated some time ago: https://nodejs.org/api/deprecations.html#DEP0040

Steps to Reproduce:
Install and use the HubSpot Node.js API Client in a project.
Run the project using Node.js 22.12.0 or newer.
Observe the deprecation warning in the console.

Suggested Resolution:
Identify the dependency in this package (or its sub-dependencies) that relies on punycode and replace it with a maintained alternative.

** Follow up: the root cause appears to be ESLint 6.8.0 (released 5 years ago).

[jwhitmarsh]

It looks like this also comes from using the previous major version of node-fetch

├─┬ @hubspot/api-client@12.0.1
│ └─┬ node-fetch@2.7.0
│   └─┬ whatwg-url@14.1.0 invalid: "^5.0.0" from node_modules/node-fetch
│     └─┬ tr46@5.0.0
│       └── punycode@2.3.1

npm info node-fetch

node-fetch@3.3.2 | MIT | deps: 3 | versions: 96
A light-weight module that brings Fetch API to node.js
https://github.com/node-fetch/node-fetch

[gkabov]

any update on this?

[joshsmonta]

Do we have any updates on this one?

[ksvirkou-hubspot]

Hi everyone,
Thank you for reporting this issue.

The problem has been resolved in version 13.0.1 or later of the SDK.
Please update to the latest version.

[martijnimhoff]

How is this fixed? As far as I can tell, the latest version of the SDK is still using node-fetch 2.7.0, which still has the issue.

[joshsmonta]

DeprecationWarning is still present on the latest version.