Skip to content

Commit 10899fd

Browse files
authored
Merge pull request #761 from HubSpot/avoid-redundant-message
Only add originating message if it is different from the default message
2 parents 1eb9c1d + c9ff51c commit 10899fd

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

src/main/java/com/hubspot/jinjava/el/ExpressionResolver.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,16 +186,19 @@ public Object resolveExpression(String expression) {
186186
)
187187
);
188188
} else {
189-
final String exceptionMessage = String.format(
189+
String originatingException = getRootCauseMessage(e);
190+
final String combinedMessage = String.format(
190191
"%s%nOriginating Exception:%n%s",
191192
e.getMessage(),
192-
getRootCauseMessage(e)
193+
originatingException
193194
);
194195
interpreter.addError(
195196
TemplateError.fromException(
196197
new TemplateSyntaxException(
197-
exceptionMessage,
198-
e.getMessage(),
198+
expression,
199+
StringUtils.endsWith(originatingException, e.getMessage())
200+
? e.getMessage()
201+
: combinedMessage,
199202
interpreter.getLineNumber(),
200203
e
201204
)

0 commit comments

Comments
 (0)