bugfix and optimize outer product decision

Author: HubertKrawczyk

src/main/java/org/apache/sysds/runtime/einsum/EOpNodeBinary.java

@@ -269,7 +269,7 @@ public MatrixBlock computeEOpNode(ArrayList<MatrixBlock> inputs, int numThreads,
                 res = LibMatrixMult.matrixMult(left,right, new MatrixBlock(), numThreads);
             }
             case aB_aC -> {
-                if(false && LibMatrixMult.isSkinnyRightHandSide(left.getNumRows(), left.getNumColumns(), right.getNumRows(), right.getNumColumns(), true)){
+                if(false && LibMatrixMult.isSkinnyRightHandSide(left.getNumRows(), left.getNumColumns(), right.getNumRows(), right.getNumColumns(), false)){
                     res = new MatrixBlock(left.getNumColumns(), right.getNumColumns(),false);
                     res.allocateDenseBlock();
                     double[] m1 = left.getDenseBlock().values(0);
@@ -341,7 +341,7 @@ public EOpNode reorderChildrenAndOptimize(EOpNode parent, Character outChar1, Ch
 				var tmpDim1 = dim1;   dim1 = dim2;     dim2 = tmpDim1;
             }
 			if(EinsumCPInstruction.FUSE_OUTER_MULTIPLY && left instanceof EOpNodeFuse fuse && fuse.einsumRewriteType == EOpNodeFuse.EinsumRewriteType.AB_BA_B_A__AB &&
-				LibMatrixMult.isSkinnyRightHandSide(left.dim1, left.dim2,  right.dim1, right.dim2, true)) {
+				left.dim1 * left.dim2 * 8 > LibMatrixMult.L3_CACHESIZE && LibMatrixMult.isSkinnyRightHandSide(left.dim1, left.dim2,  right.dim1, right.dim2, false)) {
 				fuse.operands.get(4).add(right);
 				fuse.einsumRewriteType = EOpNodeFuse.EinsumRewriteType.AB_BA_B_A_AZ__BZ;
 				fuse.c1 = fuse.c2;

src/main/java/org/apache/sysds/runtime/einsum/EOpNodeFuse.java

@@ -202,7 +202,7 @@ else if(chars.charAt(1)==b){
                 if(AZCandidates.size()==1){
                     if(!doSumB) {
                         // check if outer is possible AB,...,AZ->BZ
-                        if(!EinsumCPInstruction.FUSE_OUTER_MULTIPLY || !LibMatrixMult.isSkinnyRightHandSide(charToSize.get(AB.charAt(0)), charToSize.get(AB.charAt(1)),  charToSize.get(AB.charAt(0)),charToSize.get(AZCandidates.iterator().next().charAt(1)),true)) {
+                        if(!EinsumCPInstruction.FUSE_OUTER_MULTIPLY || !LibMatrixMult.isSkinnyRightHandSide(charToSize.get(AB.charAt(0)), charToSize.get(AB.charAt(1)),  charToSize.get(AB.charAt(0)),charToSize.get(AZCandidates.iterator().next().charAt(1)),false)) {
                             includeAz=false;
                         }
                     }
@@ -264,7 +264,7 @@ else if(chars.charAt(1)==b){
                 c1 = azC2;
             }
             else if (EinsumCPInstruction.FUSE_OUTER_MULTIPLY) {
-                if(LibMatrixMult.isSkinnyRightHandSide(charToSize.get(AB.charAt(0)), charToSize.get(AB.charAt(1)),  charToSize.get(AB.charAt(0)),charToSize.get(azC2),false)){
+                if(charToSize.get(AB.charAt(0)) * charToSize.get(AB.charAt(1)) * 8 > LibMatrixMult.L3_CACHESIZE && LibMatrixMult.isSkinnyRightHandSide(charToSize.get(AB.charAt(0)), charToSize.get(AB.charAt(1)),  charToSize.get(AB.charAt(0)),charToSize.get(azC2),false)){
                     if (outChar1 == azC2 && outChar2 == b) {
                         t = EinsumRewriteType.AB_BA_B_A_AZ__ZB;
                         c1 = azC2;
@@ -280,10 +280,12 @@ else if (EinsumCPInstruction.FUSE_OUTER_MULTIPLY) {
                     }
 
                 }else{
+					doSumA=false;
                     t=null;
                     AZs=new ArrayList<>();
                 }
             }else{
+				doSumA=false;
                 t=null;
                 AZs=new ArrayList<>();
             }