Merge pull request #209 from HughParsonage/release-2020-03-20

Release 2020 03 20

Author: HughParsonage

DESCRIPTION

@@ -1,8 +1,8 @@
 Package: grattan
 Type: Package
 Title: Australian Tax Policy Analysis
-Version: 1.8.0.0
-Date: 2019-11-16
+Version: 1.8.0.1
+Date: 2020-03-16
 Authors@R: c(person("Hugh", "Parsonage", role = c("aut", "cre"), email = "hugh.parsonage@gmail.com"),
               person("Tim", "Cameron", role = "aut"),
               person("Brendan", "Coates", role = "aut"),
@@ -35,7 +35,7 @@ Imports:
     zoo (>= 1.5-5)
 LinkingTo: 
     Rcpp
-RoxygenNote: 6.1.1
+RoxygenNote: 7.0.2
 Suggests:
     curl,
     dplyr,

NEWS.md

@@ -1,24 +1,12 @@
-## 1.8.0.0
+## 1.8.0.1
 
-### Potentially breaking changes
-
-* Pacakage `fy` is now used for operations involving financial years, notably validation of 
-  input.  This has led to changes in error messages (below) as well as the weakening
-  of some tests to omit checks of class attributes which were never intended to be 
-  relied on.
-  
-  ```r
-  # Prev:
-  fy2date("foo")
-  #> Error: fy.yr contains non-FYs.
-  
-  # Now
-  #> Error: `x = "foo"` was not a valid financial year.
-  ```
+### Bug fixes
+Fixed issue with stringsAsFactors = FALSE being inconsistently applied
+with R 4.0
 
 ### Data
 
-* Update wage and labour force data
+* Update wage, CPI, and labour force data
 
 
 

R/carer_payment.R

@@ -76,7 +76,15 @@ carer_payment <- function(Date = NULL,
   }
 
   class(fy.year) <- c("fy", "character")  # for cbind.data.frame method
-  input <- data.table(do.call(cbind.data.frame, mget(ls())))
+  
+  the_args <- copy(ls())
+  input <- data.table(ordering = seq_along(Date))
+  
+  for (j in the_args) {
+    v <- get(j)
+    set(input, j = j, value = rep_len(v, nrow(input)))
+  }
+  
 
   #Rates, income test, and asset test same as age pension
 

R/cpi_inflator.R

@@ -12,7 +12,7 @@
 #' If the SDMX connection fails, a message is emitted (not a warning) and
 #' the function contines as if \code{useABSConnection = FALSE}.
 #' 
-#' The internal data was updated on 2019-10-29 to 2019-Q2. 
+#' The internal data was updated on 2020-03-16 to 2019-Q4. 
 #' If using \code{useABSConnection = TRUE}, ensure you have \code{rsdmx (>= 0.5-10)} up-to-date.
 #' @param allow.projection Should projections beyond the ABS's data be allowed?
 #' @param accelerate.above An integer setting the threshold for 'acceleration'. 

R/cpi_inflator_quarters.R

@@ -4,7 +4,7 @@
 #' @param to_qtr (date in quarters) the date to be inflated to, where nominal price = real price. Must be of the form "YYYY-Qq" e.g. "1066-Q2".
 #' @param adjustment Should there be an adjustment made to the index? Adjustments include 'none' (no adjustment), 'seasonal', or 'trimmed' [referring to trimmed mean]. By default, \code{seasonal}.
 #' @param useABSConnection Should the function connect with ABS.Stat via an SDMX connection? By default set to \code{FALSE} in which case a pre-prepared index table is used. This is much faster and more reliable (in terms of errors), though of course relies on the package maintainer to keep the tables up-to-date.
-#' The internal data was updated on 2019-10-29 to 2019-Q2.
+#' The internal data was updated on 2020-03-16 to 2019-Q4.
 #' If using \code{useABSConnection = TRUE}, ensure you have \code{rsdmx (>= 0.5-10)} up-to-date.
 #' @return A vector of real prices.
 #' @export

R/lf_inflator.R

@@ -15,7 +15,7 @@
 #' If the SDMX connection fails, a message is emitted (not a warning) and
 #' the function contines as if \code{useABSConnection = FALSE}.
 #' 
-#' The internal data was updated on 2019-11-15 to 2019-10-01.
+#' The internal data was updated on 2020-03-16 to 2020-01-01.
 #' @param allow.projection Logical. Should projections be allowed?
 #' @param use.month An integer (corresponding to the output of \code{data.table::month}) representing the month of the series used for the inflation.
 #' @param forecast.series Whether to use the forecast mean, or the upper or lower boundaries of the prediction intervals.

R/pension_supplement.R

@@ -16,7 +16,7 @@
 #'  payment, with a message.
 #' @param overseas_absence Will the individual be living outside of Australia 
 #' for more than 6 weeks of the upcoming year?
-#' @param seperated_couple Is the individual part of an illness separated couple,
+#' @param separated_couple Is the individual part of an illness separated couple,
 #'  respite care couple, or partner imprisoned?
 #' 
 #' @author Matthew Katzen
@@ -33,11 +33,11 @@ pension_supplement <- function(has_partner = FALSE,
                                qualifying_payment = 'age_pension',
                                per = c("year", "fortnight", "quarter"),
                                overseas_absence = FALSE,
-                               seperated_couple = FALSE){
+                               separated_couple = FALSE){
 
 
 
-  if (any(!has_partner & seperated_couple)) {
+  if (any(!has_partner & separated_couple)) {
     stop("incompatible values of `has_partner` and `partner_seperated`")
   }
 
@@ -61,7 +61,16 @@ pension_supplement <- function(has_partner = FALSE,
   # Convert arguments to data table
   ls_np <- ls()[ls() != "per"]
   class(fy.year) <- c("fy", "character")
-  input <- data.table(do.call(cbind.data.frame, mget(ls_np))) 
+  input <-
+    data.table(has_partner = has_partner,
+               age = age,
+               n_dependants = n_dependants,
+               parenting_payment = parenting_payment,
+               Date = Date,
+               fy.year = fy.year,
+               qualifying_payment = qualifying_payment,
+               overseas_absence = overseas_absence,
+               separated_couple = separated_couple)
 
   eligible <- NULL
   input[, eligible := if_else(qualifying_payment %in% c('abstudy', 'austudy', 'parenting_payment', 'partner_allowance', 'special_benefit', 'widow_allowance'),
@@ -72,7 +81,7 @@ pension_supplement <- function(has_partner = FALSE,
 
   max_rate_March_2016 <- NULL
   input[, max_rate_March_2016 :=
-          if_else(has_partner & !seperated_couple,
+          if_else(has_partner & !separated_couple,
                   49,
                   65)]
 

R/sysdata.rda

@@ -10,7 +10,7 @@
 #' If the SDMX connection fails, a message is emitted (not a warning) and
 #' the function contines as if \code{useABSConnection = FALSE}.
 #' 
-#' The internal data was updated on 2019-11-15 to 2019-Q3. 
+#' The internal data was updated on 2020-03-16 to 2019-Q4. 
 #' @param allow.projection If set to \code{TRUE} the \code{forecast} package is used to project forward, if required. 
 #' @param forecast.series Whether to use the forecast mean, or the upper or lower boundaries of the prediction intervals. A fourth option \code{custom} allows manual forecasts to be set.
 #' @param forecast.level The prediction interval to be used if \code{forecast.series} is \code{upper} or \code{lower}.

R/wage_inflator.R

@@ -3,34 +3,12 @@ This is a package update
 ## Test results
 0 ERRORS | 0 WARNINGS | 1-2 NOTEs
 
-### Test environments:
-* Local Windows CRAN 3.6.1
-* Travis-CI: Ubuntu 14.04. R 3.5, 3.6, and dev (r76539)
-* Appveyor: dev (r76446) and release.
-* winbuilder: dev (r76539) and release.
+
 
 
 
 NOTES:
 
-Package archival / previous violation of policy.
-  ==> Vignettes using package 'taxstats' is now off by default
-  ==> Installation of taxstats packages now requires manual setting of 
-      environment variable
-  
-Possibly mis-spelled words in DESCRIPTION: ...
-  ==> Spellings are correct: 'repos' and 'taxstats' cannot be quoted as they are
-      within R code.
-  
-URLs in angle brackets:
-  ==> Not appropriate since the URL is within R code.
-
-Suggests or Enhances not in mainstream repositories: ...
-  ==> Normal due to taxstats dependency
-
-## Note to CRAN: moderately-large vignette
-The vignette is quite lengthy and, if the environment variable is set,
-installs package 'taxstats', a 58 MB source package,
-each time the package is checked. 
+stringsAsFactors = TRUE | FALSE both work now