chore(backend): removes deprecated functions.

Author: HugoFara

.psalm/stubs.php

@@ -73,22 +73,6 @@ function getVersionNumber(): string {}
 // They delegate to namespaced implementations.
 // =============================================================================
 
-// ---------------------------------------------------------------------------
-// From TextParsingService.php (global namespace section)
-// ---------------------------------------------------------------------------
-
-/**
- * @param array $matches
- * @param string $noSentenceEnd
- * @return string
- * @see \Lwt\Services\TextParsingService::findLatinSentenceEnd()
- */
-function find_latin_sentence_end($matches, $noSentenceEnd): string {}
-
-// ---------------------------------------------------------------------------
-// From MediaService.php (global namespace section)
-// ---------------------------------------------------------------------------
-
 // ---------------------------------------------------------------------------
 // From ExportService.php / export_helpers.php
 // ---------------------------------------------------------------------------
@@ -102,19 +86,6 @@ function find_latin_sentence_end($matches, $noSentenceEnd): string {}
  */
 function getWordTagList(int $wid, string $before = ' ', int $brack = 1, int $tohtml = 1): string {}
 
-/**
- * @param string $s
- * @param string $regexword
- * @return string
- */
-function maskTermInSentence($s, $regexword): string {}
-
-/**
- * @param string $s
- * @return string
- */
-function replTabNl($s): string {}
-
 /**
  * @param string $ann
  * @return string|false

phpdoc.dist.xml

@@ -15,7 +15,8 @@
                 <path>.</path>
             </source>
             <ignore hidden="true" symlinks="true">
-                <path>vendor</path>
+                <path>vendor/*</path>
+                <path>.psalm/*</path>
             </ignore>
             <default-package-name>Lwt</default-package-name>
         </api>

src/backend/Core/Database/TextParsing.php

@@ -15,13 +15,12 @@
 
 namespace Lwt\Database;
 
-require_once __DIR__ . '/../../Services/TextParsingService.php';
-
 use Lwt\Core\Globals;
 use Lwt\Core\StringUtils;
 use Lwt\Core\Utils\ErrorHandler;
 use Lwt\Database\QueryBuilder;
 use Lwt\Database\UserScopedQuery;
+use Lwt\Services\TextParsingService;
 
 /**
  * Text parsing and processing utilities.
@@ -514,13 +513,10 @@ private static function applyWordSplitting(
         string $termchar
     ): string {
         // "\r" => Sentence delimiter, "\t" and "\n" => Word delimiter
+        $service = new TextParsingService();
         $text = preg_replace_callback(
             "/(\S+)\s*((\.+)|([$splitSentence]))([]'`\"”)‘’‹›“„«»』」]*)(?=(\s*)(\S+|$))/u",
-            // Arrow functions were introduced in PHP 7.4
-            //fn ($matches) => find_latin_sentence_end($matches, $noSentenceEnd)
-            function ($matches) use ($noSentenceEnd) {
-                return \find_latin_sentence_end($matches, $noSentenceEnd);
-            },
+            fn ($matches) => $service->findLatinSentenceEnd($matches, $noSentenceEnd),
             $text
         );
         // Paragraph delimiters become a combination of ¶ and carriage return \r

src/backend/Services/ExportService.php

@@ -427,98 +427,3 @@ private function sendDownloadResponse(string $content, string $filename): never
 }
 
 } // End namespace Lwt\Services
-
-// =============================================================================
-// Legacy Function Wrappers (for backward compatibility)
-// =============================================================================
-
-namespace {
-
-use Lwt\Services\ExportService;
-
-/**
- * Export terms to Anki format.
- *
- * @param string $sql SQL query to retrieve terms
- *
- * @return never
- *
- * @deprecated Use ExportService::exportAnki() instead
- */
-function ankiExport(string $sql)
-{
-    (new ExportService())->exportAnki($sql);
-}
-
-/**
- * Export terms to TSV format.
- *
- * @param string $sql SQL query to retrieve terms
- *
- * @return never
- *
- * @deprecated Use ExportService::exportTsv() instead
- */
-function tsvExport(string $sql)
-{
-    (new ExportService())->exportTsv($sql);
-}
-
-/**
- * Export terms using flexible template.
- *
- * @param string $sql SQL query to retrieve terms
- *
- * @return never
- *
- * @deprecated Use ExportService::exportFlexible() instead
- */
-function flexibleExport(string $sql)
-{
-    (new ExportService())->exportFlexible($sql);
-}
-
-/**
- * Replace all whitespace characters with simple space.
- *
- * @param string $s String to parse
- *
- * @return string String with normalized whitespace
- *
- * @deprecated Use ExportService::replaceTabNewline() instead
- */
-function replTabNl(string $s): string
-{
-    return ExportService::replaceTabNewline($s);
-}
-
-/**
- * Mask the term in a sentence by replacing characters with bullets.
- *
- * @param string $s         Sentence with term marked by {} brackets
- * @param string $regexword Regex pattern for word characters
- *
- * @return string Sentence with term characters replaced by bullets
- *
- * @deprecated Use ExportService::maskTermInSentence() instead
- */
-function maskTermInSentence(string $s, string $regexword): string
-{
-    return ExportService::maskTermInSentence($s, $regexword);
-}
-
-/**
- * Mask the term in a sentence by replacing it with "[...]".
- *
- * @param string $s Sentence with term marked by {} brackets
- *
- * @return string Sentence with term replaced by "[...]"
- *
- * @deprecated Use ExportService::maskTermInSentenceV2() instead
- */
-function maskTermInSentenceV2(string $s): string
-{
-    return ExportService::maskTermInSentenceV2($s);
-}
-
-} // End global namespace

src/backend/Services/SentenceService.php

@@ -758,78 +758,6 @@ public function renderExampleSentencesArea(int $lang, string $termlc, string $ta
 
 use Lwt\Services\SentenceService;
 
-/**
- * Return a SQL string to find sentences containing a word.
- *
- * @param string $wordlc Word to look for in lowercase
- * @param int    $lid    Language ID
- *
- * @return string Query in SQL format
- *
- * @see SentenceService::buildSentencesContainingWordQuery()
- */
-function sentencesContainingWordLcQuery(string $wordlc, int $lid): string
-{
-    $service = new SentenceService();
-    return $service->buildSentencesContainingWordQuery($wordlc, $lid);
-}
-
-
-/**
- * Perform a SQL query to find sentences containing a word.
- *
- * @param int|null $wid    Word ID or mode
- * @param string   $wordlc Word to look for in lowercase
- * @param int      $lid    Language ID
- * @param int      $limit  Maximum number of sentences to return
- *
- * @return \mysqli_result|false Query result or false on failure
- *
- * @see SentenceService::findSentencesFromWord()
- */
-function sentencesFromWord(?int $wid, string $wordlc, int $lid, int $limit = -1): \mysqli_result|false
-{
-    $service = new SentenceService();
-    return $service->findSentencesFromWord($wid, $wordlc, $lid, $limit);
-}
-
-/**
- * Format the sentence(s) $seid containing $wordlc highlighting $wordlc.
- *
- * @param int    $seid   Sentence ID
- * @param string $wordlc Term text in lower case
- * @param int    $mode   Mode for sentence context
- *
- * @return string[] [0]=html, word in bold, [1]=text, word in {}
- *
- * @see SentenceService::formatSentence()
- */
-function getSentence(int $seid, string $wordlc, int $mode): array
-{
-    $service = new SentenceService();
-    return $service->formatSentence($seid, $wordlc, $mode);
-}
-
-/**
- * Return sentences containing a word.
- *
- * @param int      $lang   Language ID
- * @param string   $wordlc Word to look for in lowercase
- * @param int|null $wid    Word ID
- * @param int|null $mode   Sentences to get
- * @param int      $limit  Maximum number of sentences to return
- *
- * @return string[][] Array of sentences found
- *
- * @see SentenceService::getSentencesWithWord()
- */
-function sentencesWithWord(int $lang, string $wordlc, ?int $wid, ?int $mode = 0, int $limit = 20): array
-{
-    $service = new SentenceService();
-    return $service->getSentencesWithWord($lang, $wordlc, $wid, $mode, $limit);
-}
-
-
 /**
  * Prepare the area for example sentences of a word.
  *
@@ -846,24 +774,4 @@ function exampleSentencesArea(int $lang, string $termlc, string $selector, int $
     echo $service->renderExampleSentencesArea($lang, $termlc, $selector, $wid);
 }
 
-
-/**
- * Show 20 sentences containing $wordlc.
- *
- * @param int      $lang      Language ID
- * @param string   $wordlc    Term in lower case.
- * @param int|null $wid       Word ID
- * @param string   $jsctlname Path for the textarea
- * @param int      $mode      Mode for sentence context
- *
- * @return string HTML-formatted string
- *
- * @see SentenceService::get20Sentences()
- */
-function get20Sentences(int $lang, string $wordlc, ?int $wid, string $jsctlname, int $mode): string
-{
-    $service = new SentenceService();
-    return $service->get20Sentences($lang, $wordlc, $wid, $jsctlname, $mode);
-}
-
 } // End global namespace