fix(annotation): many japanese annotations were not displaying #101

Author: HugoFara

CHANGELOG.md

@@ -67,6 +67,11 @@ ones are marked like "v1.0.0-fork".
 
 ### Fixed
 
+* **Japanese Annotations** ([#101](https://github.com/HugoFara/lwt/issues/101)):
+  Fixed annotations not displaying correctly in Japanese texts. The
+  `annotationToJson()` function was using an off-by-one index that didn't
+  match the `Ti2Order` values used by the frontend, causing approximately
+  50% of annotations to fail to display.
 * **Text Parsing** ([#114](https://github.com/HugoFara/lwt/issues/114)): Fixed
   last word of text not being recognized when text ends without punctuation.
   Words at the end of a text are now correctly identified regardless of trailing

src/backend/Services/AnnotationService.php

@@ -263,7 +263,7 @@ public function annotationToJson(string $ann): string|false
         foreach ($items as $item) {
             $vals = preg_split('/[\t]/u', $item);
             if (count($vals) > 3 && $vals[0] >= 0 && $vals[2] > 0) {
-                $arr[intval($vals[0]) - 1] = array($vals[1], $vals[2], $vals[3]);
+                $arr[intval($vals[0])] = array($vals[1], $vals[2], $vals[3]);
             }
         }
         $json_data = json_encode($arr);

tests/backend/Core/Text/AnnotationManagementTest.php

@@ -25,28 +25,30 @@ protected function setUp(): void
 
     /**
      * Test annotation to JSON conversion
+     *
+     * @since 2.9.0 Annotation keys now match Ti2Order directly (no offset)
      */
     public function testAnnotationToJson(): void
     {
         // Empty annotation
         $this->assertEquals('{}', $this->annotationService->annotationToJson(''));
 
-        // Single annotation
+        // Single annotation - key should match the order value (1)
         $annotation = "1\tword\t5\ttranslation";
         $result = $this->annotationService->annotationToJson($annotation);
         $this->assertJson($result);
         $decoded = json_decode($result, true);
-        $this->assertArrayHasKey(0, $decoded);
-        $this->assertEquals(['word', '5', 'translation'], $decoded[0]);
+        $this->assertArrayHasKey(1, $decoded);
+        $this->assertEquals(['word', '5', 'translation'], $decoded[1]);
 
-        // Multiple annotations
+        // Multiple annotations - keys should match order values (1 and 2)
         $annotation = "1\tword1\t5\ttrans1\n2\tword2\t3\ttrans2";
         $result = $this->annotationService->annotationToJson($annotation);
         $this->assertJson($result);
         $decoded = json_decode($result, true);
         $this->assertCount(2, $decoded);
-        $this->assertEquals(['word1', '5', 'trans1'], $decoded[0]);
-        $this->assertEquals(['word2', '3', 'trans2'], $decoded[1]);
+        $this->assertEquals(['word1', '5', 'trans1'], $decoded[1]);
+        $this->assertEquals(['word2', '3', 'trans2'], $decoded[2]);
     }
 
     /**
@@ -69,11 +71,11 @@ public function testAnnotationToJsonEdgeCases(): void
         $result = $this->annotationService->annotationToJson($annotation);
         $this->assertJson($result);
 
-        // Unicode in annotations
+        // Unicode in annotations - key should match order value (1)
         $annotation = "1\t日本語\t5\ttranslation";
         $result = $this->annotationService->annotationToJson($annotation);
         $this->assertJson($result);
         $decoded = json_decode($result, true);
-        $this->assertStringContainsString('日本語', $decoded[0][0]);
+        $this->assertStringContainsString('日本語', $decoded[1][0]);
     }
 }