chore(psalm): simplifying the psalm config, removing stubs at last.

Author: HugoFara

.psalm/stubs.php

@@ -8,9 +8,6 @@
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
 >
-    <stubs>
-        <file name=".psalm/stubs.php" />
-    </stubs>
     <projectFiles>
         <directory name="." />
         <ignoreFiles>
@@ -19,7 +16,6 @@
             <directory name="assets" />
             <directory name="docs" />
             <directory name="src/tools" />
-            <directory name=".psalm" />
             <directory name="tests" />
         </ignoreFiles>
     </projectFiles>
@@ -91,13 +87,6 @@
             </errorLevel>
         </UnusedClass>
 
-        <!-- Legacy files may be missing during refactoring -->
-        <MissingFile>
-            <errorLevel type="suppress">
-                <directory name="src/backend/Controllers" />
-            </errorLevel>
-        </MissingFile>
-
         <!-- Views call global functions that may be dynamically loaded -->
         <UndefinedFunction>
             <errorLevel type="suppress">

psalm.xml

@@ -83,11 +83,6 @@ public function __construct(string $basePath)
      */
     public function bootstrap(): void
     {
-        // Define base path constant if not already defined
-        if (!defined('LWT_BASE_PATH')) {
-            define('LWT_BASE_PATH', $this->basePath);
-        }
-
         // Determine if we're in debug mode (development)
         $debug = $this->isDebugMode();
 
@@ -250,8 +245,8 @@ public function run(): void
             return;
         }
 
-        // Initialize router with DI container
-        $router = new Router($this->container);
+        // Initialize router with base path and DI container
+        $router = new Router($this->basePath, $this->container);
 
         // Load route configuration
         require_once $this->basePath . '/src/backend/Router/routes.php';

src/backend/Application.php

@@ -538,30 +538,6 @@ public function display(array $params): void
         PageLayoutHelper::renderPageEnd();
     }
 
-    /**
-     * Print text (replaces text_print.php)
-     *
-     * @param array $params Route parameters
-     *
-     * @return void
-     */
-    public function printText(array $params): void
-    {
-        include __DIR__ . '/../Legacy/text_print.php';
-    }
-
-    /**
-     * Print plain text (replaces text_print_plain.php)
-     *
-     * @param array $params Route parameters
-     *
-     * @return void
-     */
-    public function printPlain(array $params): void
-    {
-        include __DIR__ . '/../Legacy/text_print_plain.php';
-    }
-
     /**
      * Import long text (replaces text_import_long.php)
      *

src/backend/Controllers/TextController.php

@@ -58,13 +58,22 @@ class Router
      */
     private ?Container $container;
 
+    /**
+     * Base path for resolving file paths.
+     *
+     * @var string
+     */
+    private string $basePath;
+
     /**
      * Create a new Router instance.
      *
+     * @param string         $basePath  Base path for resolving file paths
      * @param Container|null $container Optional DI container for resolving controllers
      */
-    public function __construct(?Container $container = null)
+    public function __construct(string $basePath, ?Container $container = null)
     {
+        $this->basePath = $basePath;
         $this->container = $container;
     }
 
@@ -294,7 +303,7 @@ private function resolveStaticAsset(string $path): ?array
         foreach ($mappings as $oldPrefix => $newPrefix) {
             if (str_starts_with($path, $oldPrefix)) {
                 $newPath = $newPrefix . substr($path, strlen($oldPrefix));
-                $filePath = LWT_BASE_PATH . $newPath;
+                $filePath = $this->basePath . $newPath;
 
                 if (file_exists($filePath) && is_file($filePath)) {
                     return [
@@ -312,7 +321,7 @@ private function resolveStaticAsset(string $path): ?array
         $directPaths = ['/assets/', '/docs/', '/media/'];
         foreach ($directPaths as $prefix) {
             if (str_starts_with($path, $prefix)) {
-                $filePath = LWT_BASE_PATH . $path;
+                $filePath = $this->basePath . $path;
                 if (file_exists($filePath) && is_file($filePath)) {
                     return [
                         'type' => 'static',
@@ -328,7 +337,7 @@ private function resolveStaticAsset(string $path): ?array
         // Special files at root level
         $rootFiles = ['/favicon.ico', '/UNLICENSE.md'];
         if (in_array($path, $rootFiles)) {
-            $filePath = LWT_BASE_PATH . $path;
+            $filePath = $this->basePath . $path;
             if (file_exists($filePath)) {
                 return [
                     'type' => 'static',

src/backend/Router/Router.php

@@ -179,28 +179,6 @@ public function testControllerHasDisplayMethod(): void
         $this->assertTrue(method_exists($controller, 'display'));
     }
 
-    public function testControllerHasPrintTextMethod(): void
-    {
-        if (!self::$dbConnected) {
-            $this->markTestSkipped('Database connection required');
-        }
-
-        $controller = new TextController(new \Lwt\Services\TextService(), new \Lwt\Services\LanguageService());
-
-        $this->assertTrue(method_exists($controller, 'printText'));
-    }
-
-    public function testControllerHasPrintPlainMethod(): void
-    {
-        if (!self::$dbConnected) {
-            $this->markTestSkipped('Database connection required');
-        }
-
-        $controller = new TextController(new \Lwt\Services\TextService(), new \Lwt\Services\LanguageService());
-
-        $this->assertTrue(method_exists($controller, 'printPlain'));
-    }
-
     public function testControllerHasImportLongMethod(): void
     {
         if (!self::$dbConnected) {

tests/backend/Controllers/TextControllerEditTest.php

@@ -21,7 +21,7 @@ class RouterTest extends TestCase
     protected function setUp(): void
     {
         parent::setUp();
-        $this->router = new Router();
+        $this->router = new Router(dirname(__DIR__, 3));
 
         // Save original superglobals
         $this->originalServer = $_SERVER;

tests/backend/Router/RouterTest.php

@@ -26,8 +26,8 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        $this->router = new Router();
         $this->basePath = dirname(__DIR__, 3); // Go up to project root
+        $this->router = new Router($this->basePath);
 
         // Load routes
         require_once $this->basePath . '/src/backend/Router/routes.php';