Skip to content
This repository was archived by the owner on Jun 27, 2019. It is now read-only.

Commit 1071aee

Browse files
committed
Don't expose port 9229 by default (e.g. in prod)
1 parent d1f0c7b commit 1071aee

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,10 @@ LABEL Description="This image is used to start the hc-api-feathers" Vendor="Huma
33

44
# expose the app port
55
EXPOSE 3030
6-
# chrome debugging
7-
EXPOSE 9229
86

97
# override configuration by instance name in docker container
108
ENV NODE_APP_INSTANCE=docker
9+
ENV NODE_ENV=production
1110

1211
# update unix packages
1312
RUN apk update && apk upgrade

docker-compose.override.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ version: '3'
22

33
services:
44
api:
5+
environment:
6+
- NODE_ENV=development
57
ports:
68
- "3030:3030"
79
- "9229:9229" # node inspect
10+
command: yarn run dev

docker-compose.staging.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ services:
66
hc-network:
77
ipv4_address: 172.25.0.10
88
api:
9+
environment:
10+
- NODE_ENV=development
911
networks:
1012
hc-network:
1113
ipv4_address: 172.25.0.11

0 commit comments

Comments
 (0)