Remove cucumber.json altogether

* Start and configure processes in with NODE_ENV in package.json
* Remove obsolete step definitions

Author: roschaefer

config/cucumber.json

@@ -5,8 +5,7 @@ Feature: Import a post from an organization and publish it in Human Connection
 
 
   Background:
-    Given the Human Connection API is up and running
-    And there is a user in Human Connection with these credentials:
+    Given there is a user in Human Connection with these credentials:
       | email            | password |
       | user@example.com |     1234 |
 

features/api/post.feature

@@ -4,8 +4,7 @@ Feature: Save current newsfeed filters to usersettings
   In order to see the same selection of content next time I log in
 
   Background:
-    Given the Human Connection API is up and running
-    And there is a user in Human Connection with these credentials:
+    Given there is a user in Human Connection with these credentials:
       | email            | password | isVerified |
       | user@example.com |     1234 | true       |
 

features/api/usersettings.feature

@@ -1,7 +1,6 @@
 /* eslint no-console: off */
 const { Before, AfterAll, setWorldConstructor } = require('cucumber');
 
-process.env.NODE_ENV = 'test'; // write into the test database
 const backendApp = require('../../server/app');
 
 function CustomWorld() {

features/env/database.js

@@ -6,7 +6,7 @@ const fetch = require('node-fetch');
 const { expect } = require('chai');
 const waitOn = require('wait-on');
 
-const hcBackendUrl = 'http://localhost:3030';
+const hcBackendUrl = 'http://localhost:3031';
 
 let currentUser;
 let currentUserPassword;
@@ -50,17 +50,6 @@ function postRequest(route, body, callback) {
     });
 }
 
-Given(/^the Human Connection API is up and running(?: on "http:\/\/localhost:3030")?/, (callback) => {
-  waitOn({ resources: ['tcp:3030'], timeout: 30000 }, (err) => {
-    if (err) throw (err);
-    return callback();
-  });
-});
-
-Given('there is a 3rd party application running, e.g. \'Democracy\'', () => {
-  // Just documentation
-});
-
 Given('there is a user in Human Connection with these credentials:', function (dataTable) {
   const params = dataTable.hashes()[0];
   currentUserPassword = params.password;

features/step_definitions/steps.js

@@ -46,8 +46,8 @@
     "dev:win": "npm run clear && concurrently \"mongod --dbpath /data/db\" \"wait-on tcp:27017&&cross-env NODE_ENV=development&&cross-env DEBUG=feathers&& nodemon --inspect server/\"",
     "mocha": "npm run clear && $npm_package_config_mocha",
     "mocha:mongo": "$npm_package_config_concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && npm run mocha'",
-    "cucumber": "npm run clear && concurrently --kill-others --success first 'cross-env NODE_ENV=test node server/' 'wait-on tcp:3030 && cross-env NODE_ENV=test cucumber-js'",
-    "cucumber:mongo": "npm run clear && concurrently --kill-others --success first '$npm_package_config_mongoDev &>/dev/null || sleep infinity' 'wait-on tcp:27017 && cross-env NODE_ENV=test node server/' 'wait-on tcp:3030 && cross-env NODE_ENV=test cucumber-js'"
+    "cucumber": "npm run clear && concurrently --kill-others --success first 'cross-env NODE_ENV=test node server/' 'wait-on tcp:3031 && cross-env NODE_ENV=test cucumber-js'",
+    "cucumber:mongo": "npm run clear && concurrently --kill-others --success first '$npm_package_config_mongoDev &>/dev/null || sleep infinity' 'wait-on tcp:27017 && cross-env NODE_ENV=test node server/' 'wait-on tcp:3031 && cross-env NODE_ENV=test cucumber-js'"
   },
   "config": {
     "mongoDev": "mongod --dbpath data --quiet",