fixed some env var issues

Author: appinteractive

README.md

@@ -72,7 +72,7 @@ Getting up and running is as easy as 1, 2, 3, 4 ... 5.
    > ##### IMPORTANT for WIN users: 
    > - make sure you have mongo bin directory added to your PATH
    > - if you picked another data directory during mongodb setup make sure 
-   > to change package.json scripts section for key "dev-win" so it points to
+   > to change package.json scripts section for key "dev:win" so it points to
    > the proper path. Otherwise you will get missing data path errors from mongodb.
    
    If you did it right it will seed some fake data for you and downloads some images and avatar for faster development.

package.json

@@ -34,12 +34,11 @@
   },
   "scripts": {
     "clear": "rm -Rf tmp",
-    "test": "npm run eslint && cross-env NODE_ENV=test nyc --reporter=text-summary npm run mocha",
-    "test:mongo": "npm run eslint && cross-env NODE_ENV=test nyc --reporter=text-summary npm run mocha:mongo",
-    "test:coverage": "npm run eslint && cross-env NODE_ENV=test nyc --reporter=lcovonly --reporter=text-summary npm run mocha",
+    "test": "$npm_package_config_nyc npm run mocha",
+    "test:mongo": "$npm_package_config_nyc npm run mocha:mongo",
+    "test:coverage": "$npm_package_config_nyc --reporter=lcovonly npm run mocha",
     "eslint": "eslint server/. test/. --config .eslintrc.json",
     "start": "concurrently 'mongod' 'wait-on tcp:27017 && cross-env NODE_ENV=production node server/'",
-    "start:win": "concurrently \"mongod\" \"wait-on tcp:27017 &&SET NODE_ENV=production&& node server/\"",
     "dev:debug": "npm run clear && concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && cross-env DEBUG=feathers && cross-env NODE_ENV=development nodemon --inspect server/'",
     "dev": "npm run clear && concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && cross-env DEBUG=feathers && cross-env NODE_ENV=development nodemon server/'",
     "dev:local": "sh scripts/run-local.sh",
@@ -49,6 +48,7 @@
     "mocha:mongo": "$npm_package_config_concurrently '$npm_package_config_mongoDev &>/dev/null' 'wait-on tcp:27017 && npm run mocha'"
   },
   "config": {
+    "test": "npm run eslint && cross-env NODE_ENV=test nyc --reporter=text-summary",
     "mongoDev": "mongod --dbpath data --quiet",
     "mocha": "cross-env NODE_ENV=test node_modules/mocha/bin/_mocha test/ --recursive --timeout 10000 --exit",
     "concurrently": "concurrently --kill-others --success first"
@@ -108,7 +108,7 @@
   "devDependencies": {
     "babel-eslint": "~8.2.3",
     "concurrently": "~3.5.1",
-    "cross-env": "^5.1.5",
+    "cross-env": "^5.2.0",
     "eslint": "~4.19.1",
     "istanbul": "1.1.0-alpha.1",
     "mocha": "~5.2.0",

server/mongoose.js

@@ -12,7 +12,7 @@ module.exports = function () {
     connectTimeoutMS: 10000,
     socketTimeoutMS: 10000
   }, function () {
-    if (process.NODE_ENV !== 'production' && app.get('seeder').dropDatabase === true) {
+    if (process.env.NODE_ENV !== 'production' && app.get('seeder').dropDatabase === true) {
       mongoose.connection.dropDatabase().then(() => {
         app.debug('>>>>>> DROPED DATABASE <<<<<<');
         let uploadDir = path.resolve('public/uploads');

server/seeder/development/users-admin.js

@@ -16,7 +16,7 @@ module.exports = (seederstore) => {
         coverImg: 'https://source.unsplash.com/random/1250x280',
         badgeIds: () => {
           let badges = [keys(seederstore.badges)[0]];
-          if (process.NODE_ENV !== 'production') {
+          if (process.env.NODE_ENV !== 'production') {
             badges.push(keys(seederstore.badges)[5]);
             badges.push(keys(seederstore.badges)[10]);
             badges.push(keys(seederstore.badges)[16]);

server/services/auth-management/notifier.js

@@ -124,7 +124,9 @@ module.exports = function (app) {
         app.debug('Sent email', result);
       })
       .catch(err => {
-        app.error('Error sending email', err);
+        if (process.env.NODE_ENV !== 'test') {
+          app.error('Error sending email', err);
+        }
       });
   }
 

yarn.lock

@@ -1082,11 +1082,11 @@ create-error-class@^3.0.0:
   dependencies:
     capture-stack-trace "^1.0.0"
 
-cross-env@^5.1.5:
-  version "5.1.5"
-  resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-5.1.5.tgz#31daf7f3a52ef337c8ddda585f08175cce5d1fa5"
+cross-env@^5.2.0:
+  version "5.2.0"
+  resolved "https://registry.yarnpkg.com/cross-env/-/cross-env-5.2.0.tgz#6ecd4c015d5773e614039ee529076669b9d126f2"
   dependencies:
-    cross-spawn "^5.1.0"
+    cross-spawn "^6.0.5"
     is-windows "^1.0.0"
 
 cross-spawn@^3.0.0:
@@ -1104,6 +1104,16 @@ cross-spawn@^5.0.1, cross-spawn@^5.1.0:
     shebang-command "^1.2.0"
     which "^1.2.9"
 
+cross-spawn@^6.0.5:
+  version "6.0.5"
+  resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-6.0.5.tgz#4a5ec7c64dfae22c3a14124dbacdee846d80cbc4"
+  dependencies:
+    nice-try "^1.0.4"
+    path-key "^2.0.1"
+    semver "^5.5.0"
+    shebang-command "^1.2.0"
+    which "^1.2.9"
+
 crypt@~0.0.1:
   version "0.0.2"
   resolved "https://registry.yarnpkg.com/crypt/-/crypt-0.0.2.tgz#88d7ff7ec0dfb86f713dc87bbb42d044d3e6c41b"
@@ -3621,6 +3631,10 @@ [email protected]:
   version "0.6.1"
   resolved "https://registry.yarnpkg.com/negotiator/-/negotiator-0.6.1.tgz#2b327184e8992101177b28563fb5e7102acd0ca9"
 
+nice-try@^1.0.4:
+  version "1.0.4"
+  resolved "https://registry.yarnpkg.com/nice-try/-/nice-try-1.0.4.tgz#d93962f6c52f2c1558c0fbda6d512819f1efe1c4"
+
 [email protected]:
   version "2.0.0"
   resolved "https://registry.yarnpkg.com/nocache/-/nocache-2.0.0.tgz#202b48021a0c4cbde2df80de15a17443c8b43980"
@@ -3963,7 +3977,7 @@ path-is-inside@^1.0.1, path-is-inside@^1.0.2:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/path-is-inside/-/path-is-inside-1.0.2.tgz#365417dede44430d1c11af61027facf074bdfc53"
 
-path-key@^2.0.0:
+path-key@^2.0.0, path-key@^2.0.1:
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/path-key/-/path-key-2.0.1.tgz#411cadb574c5a140d3a4b1910d40d80cc9f40b40"