soft delete comments

Author: visualjerk

server/helper/alter-items.js

@@ -0,0 +1,23 @@
+const { getItems, replaceItems } = require('feathers-hooks-common');
+
+/**
+ * Alter items in hook.data or hook.result
+ *
+ * Example usage in hook module:
+ * module.exports = (options = defaults) => alterItems(handleItem(options));
+ *
+ * handleItem() is the function in which changes are made
+ */
+module.exports = func => hook => {
+  if (!func || typeof func !== 'function') {
+    return hook;
+  }
+  let items = getItems(hook);
+  if (Array.isArray(items)) {
+    items.map(item => func(item));
+  } else if (items) {
+    items = func(items);
+  }
+  replaceItems(hook, items);
+  return hook;
+};

server/hooks/add-deleted.js

@@ -1,27 +1,24 @@
 // Remove data from deleted items
-const _ = require('lodash');
-const keepFields = [
-  '_id',
-  'deleted',
-  'createdAt',
-  'updatedAt'
-]
+const alterItems = require('../helper/alter-items');
 
-module.exports = () => hook => {
-  if (!hook.result) {
-    return hook;
-  }
-  const data = !_.isEmpty(hook.result.data) ? hook.result.data : hook.result;
+const defaults = {
+  fields: [
+    '_id',
+    'deleted',
+    'createdAt',
+    'updatedAt'
+  ]
+};
 
-  _.castArray(data).forEach(item => {
-    if(item.deleted) {
-      Object.keys(item).forEach(key => {
-        if (!keepFields.includes(key)) {
-          delete item[key];
-        }
-      });
-    }
-  });
+module.exports = (options = defaults) => alterItems(handleItem(options));
 
-  return hook;
+const handleItem = options => item => {
+  if (item.deleted) {
+    Object.keys(item).forEach(key => {
+      if (!options.fields.includes(key)) {
+        delete item[key];
+      }
+    });
+  }
+  return item;
 };

server/hooks/hide-deleted-data.js

@@ -0,0 +1,19 @@
+// Null specific fields on deleted records
+const alterItems = require('../helper/alter-items');
+
+const defaults = {
+  fields: [
+    'content'
+  ]
+};
+
+module.exports = (options = defaults) => alterItems(handleItem(options));
+
+const handleItem = options => item => {
+  if (item.deleted) {
+    options.fields.forEach(field => {
+      item[field] = 'DELETED';
+    });
+  }
+  return item;
+};

server/hooks/null-deleted-data.js

@@ -1,5 +1,5 @@
 const { authenticate } = require('feathers-authentication').hooks;
-const { unless, isProvider, populate, discard, softDelete } = require('feathers-hooks-common');
+const { unless, isProvider, populate, discard, softDelete, setNow } = require('feathers-hooks-common');
 const {
   //queryWithCurrentUser,
   associateCurrentUser,
@@ -8,7 +8,7 @@ const {
 } = require('feathers-authentication-hooks');
 const { isVerified } = require('feathers-authentication-management').hooks;
 const createExcerpt = require('../../hooks/create-excerpt');
-const addDeleted = require('../../hooks/add-deleted');
+const nullDeletedData = require('../../hooks/null-deleted-data');
 const hideDeletedData = require('../../hooks/hide-deleted-data');
 const createNotifications = require('./hooks/create-notifications');
 const createMentionNotifications = require('./hooks/create-mention-notifications');
@@ -30,29 +30,31 @@ const xssFields = ['content', 'contentExcerpt'];
 module.exports = {
   before: {
     all: [
-      softDelete(),
       xss({ fields: xssFields })
     ],
-    find: [
-      addDeleted()
+    find: [],
+    get: [
+      softDelete()
     ],
-    get: [],
     create: [
       authenticate('jwt'),
       // Allow seeder to seed comments
       unless(isProvider('server'),
         isVerified()
       ),
       associateCurrentUser(),
-      createExcerpt({ length: 180 })
+      createExcerpt({ length: 180 }),
+      softDelete()
     ],
     update: [
       authenticate('jwt'),
       isVerified(),
       unless(isProvider('server'),
         restrictToOwner()
       ),
-      createExcerpt({ length: 180 })
+      createExcerpt({ length: 180 }),
+      softDelete(),
+      setNow('updatedAt')
     ],
     patch: [
       authenticate('jwt'),
@@ -68,25 +70,31 @@ module.exports = {
                 (!_.difference(_.values(valid.$inc), _.values(hook.data.$inc)).length);
         }, restrictToOwner())
       ),
-      createExcerpt({ length: 180 })
+      createExcerpt({ length: 180 }),
+      softDelete(),
+      setNow('updatedAt'),
+      // SoftDelete uses patch to delete items
+      // Make changes to deleted items here
+      nullDeletedData({ fields: [ 'content', 'contentExcerpt' ]})
     ],
     remove: [
       authenticate('jwt'),
       isVerified(),
       unless(isProvider('server'),
         restrictToOwner()
-      )
+      ),
+      softDelete()
     ]
   },
 
   after: {
     all: [
       populate({ schema: userSchema }),
-      xss({ fields: xssFields })
+      xss({ fields: xssFields }),
+      hideDeletedData()
     ],
     find: [
-      discard('content', 'user.coverImg', 'badgeIds'),
-      hideDeletedData()
+      discard('content', 'user.coverImg', 'badgeIds')
     ],
     get: [],
     create: [