fix contribution delete shout bug

visualjerk · visualjerk · commit d5f2a3a320e8 · 2018-05-25T01:09:26.000+02:00
diff --git a/server/hooks/cleanup-related-items.js b/server/hooks/cleanup-related-items.js
@@ -25,7 +25,8 @@ const deleteItem = async (item, connection, hook) => {
     await hook.app.service(connection.service)
       .remove(null, { query });
   } catch (err) {
-    throw new Error(err);
+    hook.app.error(`issue while deleting related item '${connection.service}'`);
+    hook.app.error(query);
   }
 
 };
diff --git a/server/services/shouts/shouts.hooks.js b/server/services/shouts/shouts.hooks.js
@@ -53,9 +53,7 @@ module.exports = {
     patch: [
       setShoutCount()
     ],
-    remove: [
-      setShoutCount()
-    ]
+    remove: []
   },
 
   error: {

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@ const deleteItem = async (item, connection, hook) => {`
`25`	`25`	`await hook.app.service(connection.service)`
`26`	`26`	`.remove(null, { query });`
`27`	`27`	`} catch (err) {`
`28`		`- throw new Error(err);`
	`28`	+ hook.app.error(`issue while deleting related item '${connection.service}'`);
	`29`	`+ hook.app.error(query);`
`29`	`30`	`}`
`30`	`31`
`31`	`32`	`};`