fixed associatedCanDos hook

Author: visualjerk

package.json

@@ -110,6 +110,7 @@
     "istanbul": "1.1.0-alpha.1",
     "mocha": "~5.2.0",
     "nodemon": "~1.17.4",
+    "nyc": "^12.0.2",
     "wait-on": "~2.1.0"
   }
 }

server/services/contributions/hooks/get-associated-can-dos.js

@@ -29,30 +29,26 @@ module.exports = function (options = {}) { // eslint-disable-line no-unused-vars
       return contributionService.find({
         query: {
           type: 'cando',
-          isEnabled: true
-        }
-      }, { _populate: 'skip' })
+          isEnabled: true,
+          categoryIds: {
+            $in: categoryIds
+          },
+          $limit: limit,
+        },
+        _populate: 'skip'
+      })
         .then(({data}) => {
-          let associatedCanDos = [];
-          while (associatedCanDos.length < limit && data.length) {
-            let item = data.shift();
-            let check = categoryIds.some(id => {
-              return item.categoryIds.some(innerId => {
-                return innerId.toString() == id.toString();
-              });
-            });
-            if (check && item._id.toString() !== currentData._id.toString()) {
-              associatedCanDos.push(item);
-            }
-          }
           if (isArray) {
-            hook.result.data[0].associatedCanDos = associatedCanDos;
+            hook.result.data[0].associatedCanDos = data;
           } else {
-            hook.result.associatedCanDos = associatedCanDos;
+            hook.result.associatedCanDos = data;
           }
           return resolve(hook);
         })
-        .catch(() => {
+        .catch(err => {
+          // eslint-disable-next-line
+          console.log(err);
+          hook.app.error('issue while fetching associated candos');
           return resolve(hook);
         });
     });

test/services/contributions.test.js

@@ -12,7 +12,7 @@ const {
 } = require('../assets/contributions');
 const { categoryData } = require('../assets/categories');
 
-describe('\'contributions\' service', () => {
+describe.only('\'contributions\' service', () => {
   let user;
   let params;