Commit 1b7cc3b
committed
lots of fixes for quickstart, proper algo defaults
Implemented all three issues with real tests and no new mocks.
P1 (Rust regression after default algorithm switch)
load_by_id now loads config from the default config path instead of bare defaults, so legacy RSA fixture flows stay consistent: jacs/src/agent/mod.rs:357
Fixture env helper explicitly sets legacy RSA test context (JACS_USE_SECURITY=false, JACS_AGENT_KEY_ALGORITHM=RSA-PSS): jacs/tests/utils.rs:258
Added assertion that fixture-backed load_by_id remains RSA-PSS: jacs/tests/agent_tests.rs:72
Fixed real flaky pq2025 test behavior by isolating per-test scratch dirs (relative paths) and using real keygen/load flows: jacs/tests/pq2025_tests.rs:18
P2 (Node quickstart contract mismatch)
Runtime now gives explicit errors for missing quickstart identity and guards JS no-arg calls cleanly:
jacsnpm/simple.ts:164, jacsnpm/client.ts:205
Quickstart factory internals no longer dereference options before validation:
jacsnpm/simple.ts:495, jacsnpm/client.ts:300
Types now require name and domain:
jacsnpm/simple.d.ts:67, jacsnpm/client.d.ts:64
README examples/docs updated to required quickstart options:
jacsnpm/README.md:42, jacsnpm/README.md:48, jacsnpm/README.md:462
Added runtime contract tests for missing quickstart params:
jacsnpm/test/client.test.js:99, jacsnpm/test/simple.test.js:157
P3 (MCP agent_info path leakage)
Removed local filesystem paths from Node MCP jacs_agent_info output: jacsnpm/mcp.ts:700
Removed local filesystem paths from Python MCP jacs_agent_info output: jacspy/python/jacs/adapters/mcp.py:364
Added/updated tests asserting path fields are not exposed:
jacsnpm/test/mcp.test.js:752, jacspy/tests/test_adapters_mcp.py:181
In the docs
hat I corrected
Node README quickstart password behavior now matches runtime (JACS_SAVE_PASSWORD_FILE=true required to persist generated password): jacsnpm/README.md:48
Shared quickstart snippet now reflects both Python and Node path field names and correct password bootstrap behavior: quickstart-persistent-agent.md:1
Node simple API book page now uses required signature (quickstart(options) / quickstartSync(options)) and corrected password note: nodejs/simple-api.md:61, nodejs/simple-api.md:95, nodejs/simple-api.md:97
Python simple API book page now correctly states quickstart can auto-generate password if env is unset: python/simple-api.md:44
Fixed invalid JS quickstart syntax in streaming guide (quickstart({ ... })): guides/streaming.md:75
CLI quickstart reference examples now include required --name and --domain: reference/cli-commands.md:19, reference/cli-commands.md:32
Quick-start guide password section now clearly distinguishes Rust CLI requirements vs Python/Node auto-generation: getting-started/quick-start.md:9
Main/root README and Python README wording now avoids implying no-arg quickstart: README.md:15, jacspy/README.md:42
In algorithm guide, quickstart-valid algorithm list now excludes deprecated pq-dilithium: advanced/algorithm-guide.md:631 parent 85f8405 commit 1b7cc3b
File tree
138 files changed
+2525
-588
lines changed- binding-core/src
- docs
- jacsnpm
- examples
- src
- test
- jacspy
- examples
- http
- langchain
- python/jacs
- adapters
- src
- tests
- jacs
- docs/jacsbook
- book
- advanced
- getting-started
- guides
- integrations
- nodejs
- python
- reference
- src
- _snippets
- advanced
- getting-started
- guides
- integrations
- nodejs
- python
- reference
- src
- agent
- bin
- config
- crypt
- tests
- cross_language
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
138 files changed
+2525
-588
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | | - | |
| 15 | + | |
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
42 | 43 | | |
43 | 44 | | |
44 | 45 | | |
45 | | - | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
46 | 51 | | |
47 | 52 | | |
48 | 53 | | |
| |||
60 | 65 | | |
61 | 66 | | |
62 | 67 | | |
63 | | - | |
| 68 | + | |
64 | 69 | | |
65 | 70 | | |
66 | 71 | | |
| |||
154 | 159 | | |
155 | 160 | | |
156 | 161 | | |
157 | | - | |
| 162 | + | |
158 | 163 | | |
159 | 164 | | |
160 | 165 | | |
| |||
169 | 174 | | |
170 | 175 | | |
171 | 176 | | |
172 | | - | |
| 177 | + | |
173 | 178 | | |
174 | 179 | | |
175 | 180 | | |
176 | 181 | | |
177 | 182 | | |
178 | 183 | | |
179 | 184 | | |
180 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
181 | 189 | | |
182 | 190 | | |
183 | 191 | | |
184 | 192 | | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
185 | 201 | | |
186 | 202 | | |
187 | 203 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
853 | 853 | | |
854 | 854 | | |
855 | 855 | | |
856 | | - | |
| 856 | + | |
857 | 857 | | |
858 | 858 | | |
859 | | - | |
| 859 | + | |
860 | 860 | | |
861 | 861 | | |
862 | 862 | | |
| |||
1723 | 1723 | | |
1724 | 1724 | | |
1725 | 1725 | | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
1726 | 1740 | | |
1727 | 1741 | | |
1728 | 1742 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
218 | | - | |
219 | | - | |
| 218 | + | |
| 219 | + | |
220 | 220 | | |
221 | | - | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
222 | 226 | | |
223 | 227 | | |
224 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
225 | 233 | | |
226 | 234 | | |
227 | 235 | | |
228 | 236 | | |
229 | 237 | | |
230 | | - | |
| 238 | + | |
231 | 239 | | |
232 | 240 | | |
233 | 241 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
| 212 | + | |
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
| 209 | + | |
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| |||
Lines changed: 18 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
188 | | - | |
189 | | - | |
190 | | - | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
191 | 206 | | |
192 | 207 | | |
193 | 208 | | |
| |||
0 commit comments