Skip to content

Commit 0f04daf

Browse files
authored
Switch to get the version of the pipelines from WDL and update HCA metadata schemas (#75)
* Switch to get the version of the pipelines from WDL, update the adapter wdls and readme files. * Update HCA metadata schema versions. * Remove unused static input files to make the repo clean. * Update the example input file for submit WDL. * Update the version used in adpater WDLs. * Prepare for merging.
1 parent 65fe001 commit 0f04daf

16 files changed

+46
-204
lines changed

adapter_pipelines/Optimus/adapter.wdl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ workflow AdapterOptimus {
127127
Int max_cromwell_retries = 0
128128
Boolean add_md5s = false
129129

130-
String pipeline_tools_version = "v0.28.0"
130+
String pipeline_tools_version = "v0.29.0"
131131

132132
call GetInputs as prep {
133133
input:
@@ -217,6 +217,7 @@ workflow AdapterOptimus {
217217
use_caas = use_caas,
218218
record_http = record_http,
219219
pipeline_tools_version = pipeline_tools_version,
220-
add_md5s = add_md5s
220+
add_md5s = add_md5s,
221+
pipeline_version = analysis.pipeline_version
221222
}
222223
}

adapter_pipelines/Optimus/adapter_example_bundle_specific.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

adapter_pipelines/Optimus/adapter_example_static.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
"AdapterOptimus.reference_bundle": "bf51d668-3e14-4843-9bc7-5d676fdf0e01",
77
"AdapterOptimus.format_map": "gs://hca-dcp-mint-test-data/adapters/file_format_map.json",
88
"AdapterOptimus.method": "Optimus",
9-
"AdapterOptimus.analysis_file_version": "5.2.1",
10-
"AdapterOptimus.analysis_protocol_schema_version": "8.0.0",
11-
"AdapterOptimus.analysis_process_schema_version": "8.0.0",
9+
"AdapterOptimus.analysis_file_version": "5.3.4",
10+
"AdapterOptimus.analysis_protocol_schema_version": "8.0.3",
11+
"AdapterOptimus.analysis_process_schema_version": "8.0.3",
1212
"AdapterOptimus.run_type": "run",
1313
"AdapterOptimus.add_md5s": false
1414
}

adapter_pipelines/Optimus/adapter_example_static_demo.json

Lines changed: 0 additions & 15 deletions
This file was deleted.

adapter_pipelines/ss2_single_sample/adapter.wdl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ workflow AdapterSmartSeq2SingleCell{
8383
Int max_cromwell_retries = 0
8484
Boolean add_md5s = false
8585

86-
String pipeline_tools_version = "v0.28.2"
86+
String pipeline_tools_version = "v0.29.0"
8787

8888
call GetInputs as prep {
8989
input:
@@ -230,6 +230,7 @@ workflow AdapterSmartSeq2SingleCell{
230230
record_http = record_http,
231231
pipeline_tools_version = pipeline_tools_version,
232232
add_md5s = add_md5s,
233-
max_retries = max_cromwell_retries
233+
max_retries = max_cromwell_retries,
234+
pipeline_version = analysis.pipeline_version
234235
}
235236
}

adapter_pipelines/ss2_single_sample/adapter_example_bundle_specific.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

adapter_pipelines/ss2_single_sample/adapter_example_static.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
"AdapterSmartSeq2SingleCell.reference_bundle": "bf51d668-3e14-4843-9bc7-5d676fdf0e01",
1414
"AdapterSmartSeq2SingleCell.format_map": "gs://hca-dcp-mint-test-data/adapters/file_format_map.json",
1515
"AdapterSmartSeq2SingleCell.method": "SmartSeq2SingleCell",
16-
"AdapterSmartSeq2SingleCell.analysis_file_version": "5.2.1",
17-
"AdapterSmartSeq2SingleCell.analysis_protocol_schema_version": "8.0.0",
18-
"AdapterSmartSeq2SingleCell.analysis_process_schema_version": "8.0.0",
16+
"AdapterSmartSeq2SingleCell.analysis_file_version": "5.3.4",
17+
"AdapterSmartSeq2SingleCell.analysis_protocol_schema_version": "8.0.3",
18+
"AdapterSmartSeq2SingleCell.analysis_process_schema_version": "8.0.3",
1919
"AdapterSmartSeq2SingleCell.run_type": "run",
2020
"AdapterSmartSeq2SingleCell.add_md5s": false
2121
}

adapter_pipelines/ss2_single_sample/adapter_example_static_demo.json

Lines changed: 0 additions & 17 deletions
This file was deleted.

adapter_pipelines/submit.wdl

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,18 @@ task get_metadata {
2323
# to be unbuffered. This is the same as "-u", more info: https://docs.python.org/3/using/cmdline.html#cmdoption-u
2424
export PYTHONUNBUFFERED=TRUE
2525
26-
get-analysis-metadata \
26+
get-analysis-workflow-metadata \
2727
--analysis_output_path ${analysis_output_path} \
2828
--cromwell_url ${cromwell_url} \
2929
--use_caas ${use_caas}
3030
>>>
3131
runtime {
32-
docker: "gcr.io/broad-dsde-mint-${runtime_environment}/cromwell-metadata:v1.0.0"
32+
docker: "gcr.io/broad-dsde-mint-${runtime_environment}/cromwell-metadata:v1.1.0"
3333
maxRetries: max_retries
3434
}
3535
output {
3636
File metadata = "metadata.json"
3737
String workflow_id = read_string("workflow_id.txt")
38-
String pipeline_version = read_string("pipeline_version.txt")
3938
Array[File] http_requests = glob("request_*.txt")
4039
Array[File] http_responses = glob("response_*.txt")
4140
}
@@ -252,6 +251,8 @@ workflow submit {
252251
String pipeline_tools_version
253252
Boolean add_md5s
254253
Int max_retries = 0
254+
# Version of the pipeline, should be included in the pipeline file
255+
String pipeline_version
255256

256257
call get_metadata {
257258
input:
@@ -283,7 +284,7 @@ workflow submit {
283284
metadata_json = get_metadata.metadata,
284285
input_bundle_uuid = input_bundle_uuid,
285286
workflow_id = get_metadata.workflow_id,
286-
pipeline_version = get_metadata.pipeline_version,
287+
pipeline_version = pipeline_version,
287288
retry_timeout = retry_timeout,
288289
individual_request_timeout = individual_request_timeout,
289290
retry_multiplier = retry_multiplier,

adapter_pipelines/submit_example.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
"submit.reference_bundle": "bf51d668-3e14-4843-9bc7-5d676fdf0e01",
1818
"submit.format_map": "gs://foo/format_map.json",
1919
"submit.submit_url": "http://api.ingest.staging.data.humancellatlas.org/",
20-
"submit.method": "Ss2RsemSingleSample",
21-
"submit.schema_version": "4.6.1",
20+
"submit.method": "SmartSeq2SingleCell",
21+
"submit.analysis_file_version": "5.3.4",
22+
"submit.analysis_protocol_schema_version": "8.0.3",
23+
"submit.analysis_process_schema_version": "8.0.3",
2224
"submit.run_type": "run",
2325
"submit.runtime_environment": "dev"
2426
}

0 commit comments

Comments
 (0)