Skip to content

Commit 6143514

Browse files
authored
[heartex/label-studio] Add missing readiness probe for app deployment & fix nginx readinessProbe reference (#60)
1 parent 19a3f9e commit 6143514

File tree

3 files changed

+23
-7
lines changed

3 files changed

+23
-7
lines changed

heartex/label-studio/CHANGELOG.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# Changelog
2+
## 1.9.5
3+
### Fixes
4+
* Add missing readiness probe for app deployment app container.
5+
* Fix nginx container readiness probe reference in app deployment.
6+
27
## 1.9.3
38
### Improvements
49
* Support to omit secrets in downstream values.
@@ -28,7 +33,7 @@
2833
## 1.7.0
2934
### Improvements
3035
* Explicitly set dnsPolicy, shareProcessNamespace and enableServiceLinks.
31-
* Set shareProcessNamespace and enableServiceLinks to `false`.
36+
* Set shareProcessNamespace and enableServiceLinks to `false`.
3237

3338
## 1.6.0
3439
### Improvements

heartex/label-studio/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ home: https://labelstud.io/
55
type: application
66
icon: https://raw.githubusercontent.com/heartexlabs/label-studio/master/images/logo.png
77
# Chart version
8-
version: 1.9.4
8+
version: 1.9.5
99
# Label Studio release version
1010
appVersion: "1.16.0"
1111
kubeVersion: ">= 1.14.0-0"

heartex/label-studio/templates/app-deployment.yaml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,17 @@ spec:
146146
- name: CMD_WRAPPER
147147
value: {{ coalesce $.Values.app.cmdWrapper $.Values.global.cmdWrapper }}
148148
{{- end }}
149+
{{- if .Values.app.readinessProbe.enabled }}
150+
readinessProbe:
151+
httpGet:
152+
path: "{{ if eq .Values.app.contextPath "/" }}{{ .Values.app.readinessProbe.path }}{{ else }}{{ .Values.app.contextPath }}{{ .Values.app.readinessProbe.path }}{{ end }}"
153+
port: 8000
154+
failureThreshold: {{ .Values.app.readinessProbe.failureThreshold }}
155+
initialDelaySeconds: {{ .Values.app.readinessProbe.initialDelaySeconds }}
156+
periodSeconds: {{ .Values.app.readinessProbe.periodSeconds }}
157+
successThreshold: {{ .Values.app.readinessProbe.successThreshold }}
158+
timeoutSeconds: {{ .Values.app.readinessProbe.timeoutSeconds }}
159+
{{- end }}
149160
{{- if .Values.app.livenessProbe.enabled }}
150161
livenessProbe:
151162
httpGet:
@@ -234,11 +245,11 @@ spec:
234245
httpGet:
235246
path: "{{ if eq .Values.app.contextPath "/" }}{{ .Values.app.nginx.readinessProbe.path }}{{ else }}{{ .Values.app.contextPath }}{{ .Values.app.nginx.readinessProbe.path }}{{ end }}"
236247
port: 8085
237-
failureThreshold: {{ .Values.app.readinessProbe.failureThreshold }}
238-
initialDelaySeconds: {{ .Values.app.readinessProbe.initialDelaySeconds }}
239-
periodSeconds: {{ .Values.app.readinessProbe.periodSeconds }}
240-
successThreshold: {{ .Values.app.readinessProbe.successThreshold }}
241-
timeoutSeconds: {{ .Values.app.readinessProbe.timeoutSeconds }}
248+
failureThreshold: {{ .Values.app.nginx.readinessProbe.failureThreshold }}
249+
initialDelaySeconds: {{ .Values.app.nginx.readinessProbe.initialDelaySeconds }}
250+
periodSeconds: {{ .Values.app.nginx.readinessProbe.periodSeconds }}
251+
successThreshold: {{ .Values.app.nginx.readinessProbe.successThreshold }}
252+
timeoutSeconds: {{ .Values.app.nginx.readinessProbe.timeoutSeconds }}
242253
{{- end }}
243254
{{- if .Values.app.nginx.livenessProbe.enabled }}
244255
livenessProbe:

0 commit comments

Comments
 (0)