Skip to content
This repository was archived by the owner on Apr 18, 2024. It is now read-only.

Commit 18992af

Browse files
chore: LSDV-4993: Fix ESLint to target changed files only (#1332)
* Fix ESLint to target changed files only * Add changed file to test linter * Install packages before running ESLint * Fix deps directory * Change workflow back to master
1 parent 40b9311 commit 18992af

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/workflows/eslint.yml

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,19 @@ jobs:
4747
restore-keys: |
4848
yarn-${{ env.CACHE_NAME_PREFIX }}-${{ runner.os }}-node-${{ env.NODE }}-
4949
50-
- run: yarn install --frozen-lockfile && yarn lint
50+
- name: "Install dependencies"
51+
timeout-minutes: 1
52+
run: |
53+
set -euo pipefail
54+
yarn install --frozen-lockfile
55+
56+
- name: Run ESLint
57+
uses: tj-actions/eslint-changed-files@v18
58+
with:
59+
config_path: ".eslintrc.js"
60+
ignore_path: ".eslintignore"
61+
extra_args: "--max-warnings=0"
62+
file_extensions: |
63+
**/*.js
64+
**/*.ts
65+
**/*.tsx

src/configureStore.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import AppStore from './stores/AppStore';
22

3+
// Get environment settings
34
const getEnvironment = async () => {
45
/* istanbul ignore next */
56
if (process.env.NODE_ENV === 'development' && !process.env.BUILD_NO_SERVER) {
@@ -9,6 +10,7 @@ const getEnvironment = async () => {
910
return (await import('./env/production')).default;
1011
};
1112

13+
// Configure deafult store
1214
export const configureStore = async (params, events) => {
1315
if (params.options?.secureMode) window.LS_SECURE_MODE = true;
1416

@@ -44,4 +46,3 @@ export const configureStore = async (params, events) => {
4446

4547
return { store, getRoot: env.rootElement };
4648
};
47-

0 commit comments

Comments
 (0)