fix: LSDV-4988: Fix No Label for Dynamic Labels (#1365)

Switch off labels removal if they are missing in the config.
That's destructive action, because this is the case for predictions
for example — labels from model can mismatch labels defined in config,
but they can be observed and fixed during labeling.
This is hidden by LSDV-4988 FF.

Co-authored-by: hlomzik <[email protected]>

Author: hlomzik

src/stores/Annotation/Annotation.js

@@ -21,6 +21,7 @@ import {
   FF_LSDV_3009,
   FF_LSDV_4583,
   FF_LSDV_4832,
+  FF_LSDV_4988,
   isFF
 } from '../../utils/feature-flags';
 import { delay, isDefined } from '../../utils/utilities';
@@ -944,7 +945,9 @@ export const Annotation = types
             if (key.endsWith('labels')) {
               const hasControlTag = tagNames.has(obj.from_name) || tagNames.has('labels');
 
-              if (hasControlTag) {
+              // remove non-existent labels, it actually breaks dynamic labels
+              // and makes no reason overall — labels from predictions can be out of config
+              if (!isFF(FF_LSDV_4988) && hasControlTag) {
                 const labelsContainer = tagNames.get(obj.from_name) ?? tagNames.get('labels');
                 const value = obj.value[key];
 
@@ -966,6 +969,9 @@ export const Annotation = types
                 }
               }
 
+              // detect most relevant label tags if that one from from_name is missing
+              // can be useful for predictions in old format with config in new format:
+              // Rectangle + Labels -> RectangleLabels
               if (
                 !tagNames.has(obj.from_name) ||
                 (!obj.value[key].length && !tagNames.get(obj.from_name).allowempty)

src/utils/feature-flags.ts

@@ -240,6 +240,9 @@ export const FF_LSDV_4832 = 'fflag_feat_front_lsdv_4832_new_ranker_tag_120423_sh
  */
 export const FF_LSDV_4881 = 'fflag_fix_front_lsdv_4881_timeseries_points_missing_140423_short';
 
+/** Fix "No Label" for Dynamic Labels by switching off missing labels removal */
+export const FF_LSDV_4988 = 'fflag_fix_front_lsdv_4988_dynamic_no_label_120523_short';
+
 /**
  * Fixing issues related to selection tool functional (selecting hidden regions, onClick in Konva, interaction with regions inside selection area)
  *