Fix: feature flags default value

makseq · web-flow · commit d524d8c17fe5 · 2022-02-07T17:19:59.000+03:00
diff --git a/src/utils/feature-flags.js b/src/utils/feature-flags.js
@@ -19,5 +19,12 @@ function getFeatureFlags() {
 }
 
 export function isFF(id) {
-  return getFeatureFlags()[id] === window.APP_SETTINGS?.feature_flags_default_value;
+  const featureFlags = getFeatureFlags();
+
+  if (id in featureFlags) {
+    return featureFlags[id] === true; 
+  }
+  else {
+    return window.APP_SETTINGS?.feature_flags_default_value === true;
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -19,5 +19,12 @@ function getFeatureFlags() {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`export function isFF(id) {`
`22`		`- return getFeatureFlags()[id] === window.APP_SETTINGS?.feature_flags_default_value;`
	`22`	`+ const featureFlags = getFeatureFlags();`
	`23`	`+`
	`24`	`+ if (id in featureFlags) {`
	`25`	`+ return featureFlags[id] === true;`
	`26`	`+ }`
	`27`	`+ else {`
	`28`	`+ return window.APP_SETTINGS?.feature_flags_default_value === true;`
	`29`	`+ }`
`23`	`30`	`}`