Skip to content

Conversation

@galou
Copy link

@galou galou commented Oct 15, 2024

Moreover, model_obb defaulted to false, whereas canRotate defaults to true.

Moreover, `model_obb` defaulted to false, whereas `canRotate` defaults
to true.

Signed-off-by: Gaël Écorchard <[email protected]>
@galou
Copy link
Author

galou commented May 14, 2025

Any comment?

@makseq
Copy link
Member

makseq commented May 22, 2025

There are two issues with this PR:

  1. By default, canRotate=true in most labeling configurations, but canRotate is usually omitted from these configurations. Most users employ a simple model of bounding boxes from YOLO. So, if canRotate is used instead of model_obb, the default value should be set to true. Exactly this was done at this line -https://github.com/HumanSignal/label-studio-ml-backend/pull/650/files#diff-e618adcb4b8dc30994387450f5fd296a819c048170545f8801bdb7fda5e0ecdcL15, but it will disrupt existing projects for nearly all users who use simple bounding boxes without obb. (This was the reason why model_obb was introduced instead of using canRotate).
  2. This PR eliminates backward compatibility, causing all users who currently use model_obb in their label configurations to experience broken projects.

@galou
Copy link
Author

galou commented May 23, 2025

Ok, so I guess I can close the PR.

@galou galou closed this May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants