fix: FIT-1520: Annotations no longer load in Compare All > Side-by-side mode (again?)#9604
Open
yyassi-heartex wants to merge 3 commits intodevelopfrom
Open
fix: FIT-1520: Annotations no longer load in Compare All > Side-by-side mode (again?)#9604yyassi-heartex wants to merge 3 commits intodevelopfrom
yyassi-heartex wants to merge 3 commits intodevelopfrom
Conversation
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
PR description is not about an actual fix at all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic in the
AnnotationMixinto prevent unnecessary error logging when accessing theannotationgetter during initialization, specifically when bothFF_SIMPLE_INITandFF_DEV_3391feature flags are enabled. It also adds comprehensive unit tests to verify this behavior.Feature flag logic update:
annotationgetter inAnnotationMixinnow skips logging the "annotation accessed before store is initialized" error if bothFF_SIMPLE_INITandFF_DEV_3391feature flags are enabled, preventing false-positive error logs during certain initialization flows.Testing improvements:
AnnotationMixin.test.jsto ensure:FF_SIMPLE_INITandFF_DEV_3391are enabled andSTORE_INIT_OKis false.FF_DEV_3391is disabled, maintaining correct behavior for other scenarios.