WindowX11 extra methods `setClassHint` & `setIconData` fails on (some?) Linux distro

[IrrenWirr]

On Guix linux distro (weird ones, so beware, the issue might be an idiosyncrasy from my distro) I run
./script/run.py --jwm-version 0.4.18

and got these 2 errors:

examples/dashboard/java/Example.java:89: error: cannot find symbol
                ((WindowX11) window).setClassHint("jwm-dashboard-example"); // allows OS-wide identification of the window (e.g. icon themes, .desktop files)
                                    ^
  symbol:   method setClassHint(String)
  location: class WindowX11
examples/dashboard/java/Example.java:94: error: cannot find symbol
                    ((WindowX11) window).setIconData(info.getWidth(), info.getHeight(), i.readPixels());
                                        ^
  symbol:   method setIconData(int,int,byte[])
  location: class WindowX11
2 errors
Traceback (most recent call last):

[IrrenWirr]

Can't confirm (Still didn't manage to compile it from sources) and I don't know Java, but maybe the error is due to the casting.

Like for example the mac code does a casting via instanceof

if (window instanceof WindowMac windowMac) {
            windowMac.setSubtitle("Window Subtitle");
            windowMac.setRepresentedFilename("macos/cc/WindowMac.mm");
        }

Maybe the fix is as simple as replacing the

case X11 -> {
    ((WindowX11) window).setClassHint("jwm-dashboard-example"); // allows OS-wide identification of the window (e.g. icon themes, .desktop files)
    try {
        Bitmap i = Bitmap.makeFromImage(Image.makeDeferredFromEncodedBytes(Files.readAllBytes(Path.of("examples/dashboard/resources/linux/icon_48x48.png"))));
        ImageInfo info = i.getImageInfo();

        ((WindowX11) window).setIconData(info.getWidth(), info.getHeight(), i.readPixels());
    } catch (IOException e) {
        e.printStackTrace();
    }
}

with also instanceof, like the mac version 🤷

i.e

case X11 -> {
    if (window instanceof WindowX11 windowX11) {
        windowX11.setClassHint("jwm-dashboard-example"); // allows OS-wide identification of the window (e.g. icon themes, .desktop files)
        try {
            Bitmap i = Bitmap.makeFromImage(Image.makeDeferredFromEncodedBytes(Files.readAllBytes(Path.of("examples/dashboard/resources/linux/icon_48x48.png"))));
            ImageInfo info = i.getImageInfo();

            windowX11.setIconData(info.getWidth(), info.getHeight(), i.readPixels());
        } catch (IOException e) {
            e.printStackTrace();
        }
    }
}

[dzaima]

Those functions were added in JWM 0.4.19, so ./script/run.py --jwm-version 0.4.19 should presumably work.

[dzaima]

Oh, seems 0.4.19 was never uploaded to maven, or tagged, despite a 0.4.19 commit being created. @tonsky?

[dzaima]

Actually, I can't even run ./script/run.py --jwm-version 0.4.18 on Linux Mint; I need to apply this change so it works (or, rather, doesn't work as it didn't for you):

diff --git a/script/run.py b/script/run.py
index d4a282e..e208acf 100755
--- a/script/run.py
+++ b/script/run.py
@@ -28,7 +28,7 @@ def main():
   
   if args.jwm_version:
     classpath += [
-      build_utils.fetch_maven('io.github.humbleui.jwm', 'jwm', args.jwm_version)
+      build_utils.fetch_maven('io.github.humbleui', 'jwm', args.jwm_version)
     ]
   else:
     classpath += [

[IrrenWirr]

yeah, I did a little pull request for that, so if you push yours, dont forget to close/delete my pull request🙏
#298

[dzaima]

oh whoops I did see that but forgot :| (I'm not a maintainer here so don't have any advantage over you for a PR, am just a random contributor (..the one who happened to introduce those new 0.4.19 functions :) ))

[dzaima]

This issue can be closed, JWM 0.4.20 is available and works