nits

Author: francamps

packages/react/src/lib/VoiceProvider.tsx

@@ -232,10 +232,7 @@ export const VoiceProvider: FC<VoiceProviderProps> = ({
           if (player.isPlaying) {
             onInterruption.current(message);
           }
-          const shouldFadeOut = message.type === 'user_interruption';
-          player.clearQueue({
-            fadeOut: shouldFadeOut,
-          });
+          player.clearQueue();
         }
 
         if (

packages/react/src/lib/useSoundPlayer.ts

@@ -87,40 +87,29 @@ export const useSoundPlayer = (props: {
     }
   }, []);
 
-  const addToQueue = useCallback(
-    async (message: AudioOutputMessage) => {
-      if (!isInitialized.current || !audioContext.current) {
-        onError.current('Audio player has not been initialized');
-        return;
-      }
+  const addToQueue = useCallback(async (message: AudioOutputMessage) => {
+    if (!isInitialized.current || !audioContext.current) {
+      onError.current('Audio player has not been initialized');
+      return;
+    }
 
-      try {
-        const blob = convertBase64ToBlob(message.data);
-        const arrayBuffer = await blob.arrayBuffer();
-        const audioBuffer =
-          await audioContext.current.decodeAudioData(arrayBuffer);
-
-        const pcmData = audioBuffer.getChannelData(0);
-        workletNode.current?.port.postMessage({ type: 'audio', data: pcmData });
-
-        if (gainNode.current) {
-          const now = audioContext.current.currentTime;
-          gainNode.current.gain.cancelScheduledValues(now);
-          gainNode.current.gain.setValueAtTime(
-            isAudioMuted ? 0 : volume,
-            audioContext.current.currentTime,
-          );
-        }
+    try {
+      const blob = convertBase64ToBlob(message.data);
+      const arrayBuffer = await blob.arrayBuffer();
+      const audioBuffer =
+        await audioContext.current.decodeAudioData(arrayBuffer);
 
-        setIsPlaying(true);
-        onPlayAudio.current(message.id);
-      } catch (e) {
-        const eMessage = e instanceof Error ? e.message : 'Unknown error';
-        onError.current(`Failed to add clip to queue: ${eMessage}`);
-      }
-    },
-    [isAudioMuted, volume],
-  );
+      const pcmData = audioBuffer.getChannelData(0);
+
+      workletNode.current?.port.postMessage({ type: 'audio', data: pcmData });
+
+      setIsPlaying(true);
+      onPlayAudio.current(message.id);
+    } catch (e) {
+      const eMessage = e instanceof Error ? e.message : 'Unknown error';
+      onError.current(`Failed to add clip to queue: ${eMessage}`);
+    }
+  }, []);
 
   const stopAll = useCallback(() => {
     isInitialized.current = false;
@@ -133,7 +122,7 @@ export const useSoundPlayer = (props: {
       window.clearInterval(frequencyDataIntervalId.current);
     }
 
-    workletNode.current?.port.postMessage({ type: 'fade' });
+    workletNode.current?.port.postMessage({ type: 'fadeAndClear' });
     workletNode.current?.port.postMessage({ type: 'end' });
 
     if (analyserNode.current) {
@@ -164,22 +153,15 @@ export const useSoundPlayer = (props: {
     setFft(generateEmptyFft());
   }, []);
 
-  const clearQueue = useCallback(
-    ({
-      fadeOut,
-    }: {
-      fadeOut?: boolean;
-    } = {}) => {
-      workletNode.current?.port.postMessage({
-        type: fadeOut ? 'fade' : 'clear',
-      });
-
-      isProcessing.current = false;
-      setIsPlaying(false);
-      setFft(generateEmptyFft());
-    },
-    [],
-  );
+  const clearQueue = useCallback(() => {
+    workletNode.current?.port.postMessage({
+      type: 'fadeAndClear',
+    });
+
+    isProcessing.current = false;
+    setIsPlaying(false);
+    setFft(generateEmptyFft());
+  }, []);
 
   const setVolume = useCallback(
     (newLevel: number) => {

packages/react/src/worklets/audio-worklet.js

@@ -85,7 +85,7 @@ class AudioStreamProcessor extends AudioWorkletProcessor {
         case 'end':
           this._shouldStop = true;
           break;
-        case 'fade':
+        case 'fadeAndClear':
           this._fadeOutActive = true;
           this._fadeOutCounter = 0;
           break;
@@ -111,15 +111,15 @@ class AudioStreamProcessor extends AudioWorkletProcessor {
   process(inputs, outputs) {
     const output = outputs[0];
     const frames = output[0].length;
-    const chans = output.length;
+    const channels = output.length;
 
     const block = this._bq.read();
 
     if (block) {
-      for (let ch = 0; ch < chans; ch++) {
+      for (let ch = 0; ch < channels; ch++) {
         const out = output[ch];
         for (let i = 0; i < frames; i++) {
-          let sample = block[i * chans + ch] ?? 0;
+          let sample = block[i * channels + ch] ?? 0;
 
           // Apply fade out if active
           if (this._fadeOutActive) {
@@ -154,7 +154,7 @@ class AudioStreamProcessor extends AudioWorkletProcessor {
       return false;
     }
 
-    for (let ch = 0; ch < chans; ch++) {
+    for (let ch = 0; ch < channels; ch++) {
       output[ch].fill(0);
     }