tech: types and edge cases

Author: flavioislima

src/backend/cache.ts

@@ -3,7 +3,7 @@ import Store from 'electron-store'
 export default class CacheStore<ValueType, KeyType extends string = string> {
   private readonly store: Store
   private in_memory_store: Map<string, ValueType>
-  private using_in_memory: boolean
+  private using_in_memory: number
   private current_store: Store | Map<string, ValueType>
   private readonly lifespan: number | null
 
@@ -20,7 +20,7 @@ export default class CacheStore<ValueType, KeyType extends string = string> {
       clearInvalidConfig: true
     })
     this.in_memory_store = new Map<string, ValueType>()
-    this.using_in_memory = false
+    this.using_in_memory = 0
     this.current_store = this.store
     this.lifespan = max_value_lifespan
   }
@@ -31,7 +31,7 @@ export default class CacheStore<ValueType, KeyType extends string = string> {
    */
   public use_in_memory() {
     // Mirror store to memory map
-    this.using_in_memory = true
+    this.using_in_memory += 1
     this.in_memory_store = new Map(this.store) as Map<string, ValueType>
     this.current_store = this.in_memory_store
   }
@@ -85,8 +85,10 @@ export default class CacheStore<ValueType, KeyType extends string = string> {
   public commit() {
     if (this.using_in_memory) {
       this.store.store = Object.fromEntries(this.in_memory_store)
-      this.using_in_memory = false
-      this.current_store = this.store
+      this.using_in_memory -= 1
+      if (this.using_in_memory === 0) {
+        this.current_store = this.store
+      }
     }
   }
 }

src/backend/logger/logger.ts

@@ -35,14 +35,16 @@ export enum LogPrefix {
   Sideload = 'Sideload',
   Achievements = 'Achievements',
   Auth = 'Auth',
-  AutoUpdater = 'AutoUpdater'
+  AutoUpdater = 'AutoUpdater',
+  Steam = 'Steam'
 }
 
 export const RunnerToLogPrefixMap = {
   legendary: LogPrefix.Legendary,
   gog: LogPrefix.Gog,
   hyperplay: LogPrefix.HyperPlay,
-  sideload: LogPrefix.Sideload
+  sideload: LogPrefix.Sideload,
+  steam: LogPrefix.Steam
 }
 
 type LogInputType = unknown[] | unknown

src/backend/save_sync.ts

@@ -37,6 +37,7 @@ async function getDefaultSavePath(
       return getDefaultLegendarySavePath(appName)
     case 'gog':
       return getDefaultGogSavePaths(appName, alreadyDefinedGogSaves)
+    case 'steam':
     case 'sideload':
       return ''
   }

src/backend/shortcuts/nonesteamgame/constants.ts

@@ -5,11 +5,13 @@ const pictureExt = '.jpg'
 const coverArtSufix = 'p' + pictureExt
 const backGroundArtSufix = '_hero' + pictureExt
 const logoArtSufix = '_logo' + pictureExt
+const steamDBBaseURL = 'https://cdn.steamstatic.com/steam/apps'
 
 export {
   transparentSteamLogoHex,
   coverArtSufix,
   backGroundArtSufix,
   logoArtSufix,
-  pictureExt
+  pictureExt,
+  steamDBBaseURL
 }

src/backend/utils.ts

@@ -347,7 +347,7 @@ function removeSpecialcharacters(text: string): string {
 }
 
 async function openUrlOrFile(url: string): Promise<string | void> {
-  if (url.startsWith('http')) {
+  if (url.includes('://')) {
     return shell.openExternal(url)
   }
   return shell.openPath(url)
@@ -1205,14 +1205,15 @@ export const processIsClosed = async (pid: number) => {
 }
 
 type RunnerStore = {
-  [key in Runner]: 'Epic Games' | 'GOG' | 'HyperPlay' | 'Sideloaded'
+  [key in Runner]: 'Epic Games' | 'GOG' | 'HyperPlay' | 'Sideloaded' | 'Steam'
 }
 
 const runnerStore: RunnerStore = {
   legendary: 'Epic Games',
   gog: 'GOG',
   hyperplay: 'HyperPlay',
-  sideload: 'Sideloaded'
+  sideload: 'Sideloaded',
+  steam: 'Steam'
 }
 
 export const getStoreName = (runner: Runner) => {