Add ENABLE_SUBMISSION_WITHDRAWAL to allow enabling withdrawals

This only affects about enabling them, not whether they are in the
system.  That means that if the configuration is changed over the
lifetime of a system, things that were withdrawn when it was enabled
retain that status.

Author: Frank Duncan

docs/setup/administrators/configuration.md

@@ -76,6 +76,10 @@ The corrosponding locale dir is named: en, en_GB, en_US
 
     FORCE_LOGIN_FOR_APPLICATION = env.bool('FORCE_LOGIN_FOR_APPLICATION', False)
 
+### Allow Withdrawing of Submissions
+
+    ENABLE_SUBMISSION_WITHDRAWAL = env.bool('ENABLE_SUBMISSION_WITHDRAWAL', False)
+
 ### Set the allowed file extension for all uploads fields.
 
     FILE_ALLOWED_EXTENSIONS = ['doc', 'docx', 'odp', 'ods', 'odt', 'pdf', 'ppt', 'pptx', 'rtf', 'txt', 'xls', 'xlsx']

hypha/apply/funds/views.py

@@ -1410,6 +1410,9 @@ def post(self, request, *args, **kwargs):
         return self.withdraw(request, *args, **kwargs)
 
     def withdraw(self, request, *args, **kwargs):
+        if not settings.ENABLE_SUBMISSION_WITHDRAWAL:
+            raise PermissionDenied
+
         obj = self.get_object()
 
         if not obj.phase.permissions.can_edit(request.user):

hypha/apply/funds/workflow.py

@@ -348,7 +348,7 @@ def make_permissions(edit=None, review=None, view=None):
             'display': _('Need screening'),
             'public': _('Application Received'),
             'stage': RequestExt,
-            'permissions': default_permissions,
+            'permissions': applicant_edit_permissions,
         },
         'ext_more_info': {
             'transitions': {

hypha/core/context_processors.py

@@ -19,4 +19,5 @@ def global_vars(request):
         'SENTRY_DENY_URLS': settings.SENTRY_DENY_URLS,
         'SENTRY_DEBUG': settings.SENTRY_DEBUG,
         'SENTRY_PUBLIC_KEY': settings.SENTRY_PUBLIC_KEY,
+        'ENABLE_SUBMISSION_WITHDRAWAL': settings.ENABLE_SUBMISSION_WITHDRAWAL,
     }

hypha/settings/base.py

@@ -106,6 +106,9 @@
 # Enable users to create accounts without submitting an application.
 ENABLE_REGISTRATION_WITHOUT_APPLICATION = env.bool('ENABLE_REGISTRATION_WITHOUT_APPLICATION', False)
 
+# Allow Withdrawing of Submissions
+ENABLE_SUBMISSION_WITHDRAWAL = env.bool('ENABLE_SUBMISSION_WITHDRAWAL', False)
+
 # Project settings.
 
 # SECRET_KEY is required