Skip to content

Commit b31f475

Browse files
committed
fix: Release netty bytebuf in TestPacketRoundtrip
1 parent 4b3ec0f commit b31f475

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/test/java/net/hypixel/modapi/packet/TestPacketRoundtrip.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package net.hypixel.modapi.packet;
22

3+
import io.netty.buffer.ByteBuf;
34
import io.netty.buffer.Unpooled;
45
import net.hypixel.modapi.HypixelModAPI;
56
import net.hypixel.modapi.serializer.PacketSerializer;
@@ -24,9 +25,14 @@ private static ClientboundHypixelPacket handleServerbound(String identifier, Pac
2425
}
2526

2627
private static ClientboundHypixelPacket doPacketRoundtrip(HypixelPacket packet) {
27-
PacketSerializer serializer = new PacketSerializer(Unpooled.buffer());
28-
packet.write(serializer);
29-
return handleServerbound(packet.getIdentifier(), serializer);
28+
ByteBuf buf = Unpooled.buffer();
29+
try {
30+
PacketSerializer serializer = new PacketSerializer(buf);
31+
packet.write(serializer);
32+
return handleServerbound(packet.getIdentifier(), serializer);
33+
} finally {
34+
buf.release();
35+
}
3036
}
3137

3238
private static Stream<Arguments> packetProvider() {

0 commit comments

Comments
 (0)