Give shared the same label as its base strategy

Author: jobh

hypothesis-python/src/hypothesis/strategies/_internal/shared.py

@@ -23,16 +23,16 @@ def __init__(self, base: SearchStrategy[Ex], key: Optional[Hashable] = None):
         super().__init__()
         self.key = key
         self.base = base
-        while isinstance(self.base, SharedStrategy):
-            # Unwrap nested shares
-            self.base = self.base.base
 
     def __repr__(self) -> str:
         if self.key is not None:
             return f"shared({self.base!r}, key={self.key!r})"
         else:
             return f"shared({self.base!r})"
 
+    def calc_label(self) -> int:
+        return self.base.calc_label()
+
     # Ideally would be -> Ex, but key collisions with different-typed values are
     # possible. See https://github.com/HypothesisWorks/hypothesis/issues/4301.
     def do_draw(self, data: ConjectureData) -> Any:
@@ -44,7 +44,7 @@ def do_draw(self, data: ConjectureData) -> Any:
             drawn, other = data._shared_strategy_draws[key]
 
             # Check that the strategies shared under this key are equivalent
-            if self.base.label != other.base.label:
+            if self.label != other.label:
                 warnings.warn(
                     f"Different strategies are shared under {key=}. This"
                     " risks drawing values that are not valid examples for the strategy,"

hypothesis-python/tests/cover/test_direct_strategies.py

@@ -661,11 +661,12 @@ def test_it(a, b):
 def test_compatible_nested_shared_strategies_do_not_warn():
     shared_a = st.shared(st.integers(), key="share")
     shared_b = st.shared(st.integers(), key="share")
-    shared_c = st.shared(shared_a, key="share")
+    shared_c = st.shared(shared_a, key="nested_share")
+    shared_d = st.shared(shared_b, key="nested_share")
 
-    @given(shared_a, shared_b, shared_c)
+    @given(shared_a, shared_b, shared_c, shared_d)
     @settings(max_examples=10, phases=[Phase.generate])
-    def test_it(a, b, c):
-        assert a == b == c
+    def test_it(a, b, c, d):
+        assert a == b == c == d
 
     test_it()