Simplify, type fix

Author: jobh

hypothesis-python/src/hypothesis/internal/conjecture/data.py

@@ -706,7 +706,7 @@ def __init__(
         self._sampled_from_all_strategies_elements_message: Optional[
             tuple[str, object]
         ] = None
-        self._shared_strategy_draws: dict[Hashable, tuple[int, Any]] = {}
+        self._shared_strategy_draws: dict[Hashable, tuple[Any, "SharedStrategy"]] = {}
         self._shared_data_strategy: Optional[DataObject] = None
         self._stateful_repr_parts: Optional[list[Any]] = None
         self.states_for_ids: Optional[dict[int, RandomState]] = None

hypothesis-python/src/hypothesis/strategies/_internal/shared.py

@@ -11,7 +11,6 @@
 import warnings
 from collections.abc import Hashable
 from typing import Any, Optional
-from weakref import WeakKeyDictionary
 
 from hypothesis.errors import HypothesisWarning
 from hypothesis.internal.conjecture.data import ConjectureData
@@ -46,15 +45,11 @@ def do_draw(self, data: ConjectureData) -> Any:
 
             if other.base is not self.base:
                 # Check that the strategies shared under this key are equivalent,
-                # approximated as having equal `repr`s.
-                try:
-                    is_equivalent = self._equivalent_to[other]
-                except (AttributeError, KeyError) as e:
-                    if isinstance(e, AttributeError):
-                        self._equivalent_to = WeakKeyDictionary()
-                    is_equivalent = repr(self.base) == repr(other.base)
-                    self._equivalent_to[other] = is_equivalent
-                if not is_equivalent:
+                # approximated as having equal `repr`s. False positives are ok,
+                # false negatives (erroneous warnings) less so.
+                if not hasattr(self, "_is_compatible"):
+                    self._is_compatible = repr(self.base) == repr(other.base)
+                if not self._is_compatible:
                     warnings.warn(
                         f"Different strategies are shared under {key=}. This"
                         " risks drawing values that are not valid examples for the strategy,"