Skip to content

Remove redundant decorators on individual @overloads #4564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 14, 2025
+38 −26
Merged

Remove redundant decorators on individual @overloads #4564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3162024
Remove redundant decorators on individual `@overload`s
jorenham Oct 14, 2025
d03cdf3
Add release note for #4564
jorenham Oct 14, 2025
2221eab
add debug note for format error
Liam-DeVoe Oct 14, 2025
8a41718
spacing
Liam-DeVoe Oct 14, 2025
7745d71
attempt to deflake
Liam-DeVoe Oct 14, 2025
bc8d15a
style
Liam-DeVoe Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions hypothesis-python/RELEASE.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
RELEASE_TYPE: patch

Clean up internal ``@overload`` type annotations.
23 changes: 0 additions & 23 deletions hypothesis-python/src/hypothesis/extra/numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,6 @@ def fill_for(elements, unique, fill, name=""):


@overload
@defines_strategy(force_reusable_values=True)
def arrays(
dtype: Union["np.dtype[G]", st.SearchStrategy["np.dtype[G]"]],
shape: Union[int, st.SearchStrategy[int], Shape, st.SearchStrategy[Shape]],
Expand All @@ -431,7 +430,6 @@ def arrays(


@overload
@defines_strategy(force_reusable_values=True)
def arrays(
dtype: Union[D, st.SearchStrategy[D]],
shape: Union[int, st.SearchStrategy[int], Shape, st.SearchStrategy[Shape]],
Expand Down Expand Up @@ -625,7 +623,6 @@ def dtype_factory(kind, sizes, valid_sizes, endianness):


@overload
@defines_dtype_strategy
def unsigned_integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -634,7 +631,6 @@ def unsigned_integer_dtypes(


@overload
@defines_dtype_strategy
def unsigned_integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -643,7 +639,6 @@ def unsigned_integer_dtypes(


@overload
@defines_dtype_strategy
def unsigned_integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -652,7 +647,6 @@ def unsigned_integer_dtypes(


@overload
@defines_dtype_strategy
def unsigned_integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -661,7 +655,6 @@ def unsigned_integer_dtypes(


@overload
@defines_dtype_strategy
def unsigned_integer_dtypes(
*,
endianness: str = "?",
Expand Down Expand Up @@ -693,7 +686,6 @@ def unsigned_integer_dtypes(


@overload
@defines_dtype_strategy
def integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -702,7 +694,6 @@ def integer_dtypes(


@overload
@defines_dtype_strategy
def integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -711,7 +702,6 @@ def integer_dtypes(


@overload
@defines_dtype_strategy
def integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -720,7 +710,6 @@ def integer_dtypes(


@overload
@defines_dtype_strategy
def integer_dtypes(
*,
endianness: str = "?",
Expand All @@ -729,7 +718,6 @@ def integer_dtypes(


@overload
@defines_dtype_strategy
def integer_dtypes(
*,
endianness: str = "?",
Expand Down Expand Up @@ -757,7 +745,6 @@ def integer_dtypes(


@overload
@defines_dtype_strategy
def floating_dtypes(
*,
endianness: str = "?",
Expand All @@ -766,7 +753,6 @@ def floating_dtypes(


@overload
@defines_dtype_strategy
def floating_dtypes(
*,
endianness: str = "?",
Expand All @@ -775,7 +761,6 @@ def floating_dtypes(


@overload
@defines_dtype_strategy
def floating_dtypes(
*,
endianness: str = "?",
Expand All @@ -784,7 +769,6 @@ def floating_dtypes(


@overload
@defines_dtype_strategy
def floating_dtypes(
*,
endianness: str = "?",
Expand All @@ -793,7 +777,6 @@ def floating_dtypes(


@overload
@defines_dtype_strategy
def floating_dtypes(
*,
endianness: str = "?",
Expand Down Expand Up @@ -822,7 +805,6 @@ def floating_dtypes(


@overload
@defines_dtype_strategy
def complex_number_dtypes(
*,
endianness: str = "?",
Expand All @@ -831,7 +813,6 @@ def complex_number_dtypes(


@overload
@defines_dtype_strategy
def complex_number_dtypes(
*,
endianness: str = "?",
Expand All @@ -840,7 +821,6 @@ def complex_number_dtypes(


@overload
@defines_dtype_strategy
def complex_number_dtypes(
*,
endianness: str = "?",
Expand All @@ -849,7 +829,6 @@ def complex_number_dtypes(


@overload
@defines_dtype_strategy
def complex_number_dtypes(
*,
endianness: str = "?",
Expand Down Expand Up @@ -1175,7 +1154,6 @@ def basic_indices(


@overload
@defines_strategy()
def integer_array_indices(
shape: Shape,
*,
Expand All @@ -1184,7 +1162,6 @@ def integer_array_indices(


@overload
@defines_strategy()
def integer_array_indices(
shape: Shape,
*,
Expand Down
12 changes: 10 additions & 2 deletions hypothesis-python/tests/watchdog/test_database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,17 +119,25 @@ def test_database_listener_directory_explicit(tmp_path):
def listener(event):
events.append(event)

time_sleep(0.1)
db.add_listener(listener)
time_sleep(0.1)

db.save(b"k1", b"v1")
wait_for(lambda: events == [("save", (b"k1", b"v1"))], timeout=60)
wait_for(lambda: events == [("save", (b"k1", b"v1"))], timeout=30)

time_sleep(0.1)
db.remove_listener(listener)
time_sleep(0.1)

db.delete(b"k1", b"v1")
db.save(b"k1", b"v2")
wait_for(lambda: events == [("save", (b"k1", b"v1"))], timeout=60)
wait_for(lambda: events == [("save", (b"k1", b"v1"))], timeout=30)

time_sleep(0.1)
db.add_listener(listener)
time_sleep(0.1)

db.delete(b"k1", b"v2")
db.save(b"k1", b"v3")
wait_for(
Expand Down
26 changes: 25 additions & 1 deletion tooling/src/hypothesistooling/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,31 @@ def check_format():
print(f"{f} has incorrect start {start!r}", file=sys.stderr)
bad = True
assert not bad
check_not_changed()
try:
check_not_changed()
except Exception:
box_width = 50
inner_width = box_width - 2
content_width = inner_width - 2
msg1 = "Note: code differed after formatting."
msg2 = "To fix this, run:"
msg3 = " ./build.sh format"

lines = [
"",
" " + "*" * box_width,
" *" + " " * inner_width + "*",
" * " + msg1 + " " * (content_width - len(msg1)) + "*",
" *" + " " * inner_width + "*",
" * " + msg2 + " " * (content_width - len(msg2)) + "*",
" *" + " " * inner_width + "*",
" * " + msg3 + " " * (content_width - len(msg3)) + "*",
" *" + " " * inner_width + "*",
" " + "*" * box_width,
"",
]
print("\n".join(lines), file=sys.stderr)
raise


def check_not_changed():
Expand Down
Loading