Skip to content

Commit 6d84b0c

Browse files
committed
Optimize q_insert_tail
Fixed potential issues where head->prev might not be correctly initialized. Change-Id: Ic0aaf480e3cef5d12c082f68e1865484fd964c21
1 parent 11bbebe commit 6d84b0c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

queue.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,11 @@ bool q_insert_tail(struct list_head *head, char *s)
7575
free(new_node);
7676
return false;
7777
}
78-
INIT_LIST_HEAD(&new_node->list);
78+
79+
if (list_empty(head)) {
80+
INIT_LIST_HEAD(&new_node->list);
81+
}
82+
7983
list_add_tail(&new_node->list, head);
8084
return true;
8185
}

0 commit comments

Comments
 (0)