sonarqube fixes

Author: yuzawa-san

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/base64/AbstractBase64UrlEncoder.java

@@ -8,7 +8,7 @@
 
 public abstract class AbstractBase64UrlEncoder {
 
-  abstract protected void pad(BitStringBuilder bitString);
+  protected abstract void pad(BitStringBuilder bitString);
 
   private static final int BASE64_BITS = 6;
   /**

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/bitstring/BitStringBuilder.java

@@ -27,8 +27,8 @@ public BitStringBuilder append(boolean value) {
   }
 
   public BitStringBuilder append(BitString other) {
-    int length = other.length();
-    for (int i = 0; i < length; i++) {
+    int otherLength = other.length();
+    for (int i = 0; i < otherLength; i++) {
       append(other.getValue(i));
     }
     return this;
@@ -38,10 +38,10 @@ public int length() {
     return length;
   }
 
-  public BitStringBuilder append(BitStringBuilder rangeBitString) {
-    int length = rangeBitString.length();
-    for (int i = 0; i < length; i++) {
-      append(rangeBitString.bitSet.get(i));
+  public BitStringBuilder append(BitStringBuilder other) {
+    int otherLength = other.length();
+    for (int i = 0; i < otherLength; i++) {
+      append(other.bitSet.get(i));
     }
     return this;
   }

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/AbstractEncodableBitStringDataType.java

@@ -41,7 +41,7 @@ public void setValue(Object value) {
     } else {
       if (v instanceof Collection) {
         throw new ValidationException("Invalid value '"
-            + ((Collection<?>) v).stream().map(i -> i.toString()).collect(Collectors.joining(",")) + "'");
+            + ((Collection<?>) v).stream().map(Object::toString).collect(Collectors.joining(",")) + "'");
       } else {
         throw new ValidationException("Invalid value '" + v + "'");
       }
@@ -53,10 +53,6 @@ public boolean getHardFailIfMissing() {
     return this.hardFailIfMissing;
   }
 
-  public abstract void encode(BitStringBuilder builder);
-
-  public abstract void decode(BitString bitString);
-
   public abstract BitString substring(BitString bitString, int fromIndex) throws SubstringException;
 
   public boolean isDirty() {

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/BaseIntegerSet.java

@@ -18,7 +18,7 @@ public final boolean add(Integer value) {
     if (value == null) {
       return false;
     }
-    return addInt((Integer) value);
+    return addInt(value);
   }
 
   @Override

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/BooleanEncoder.java

@@ -6,14 +6,12 @@
 import com.iab.gpp.encoder.error.EncodingException;
 
 public class BooleanEncoder {
+  private BooleanEncoder() {}
   public static void encode(BitStringBuilder builder, Boolean value) {
-    if (value == true) {
-      builder.append(true);
-    } else if (value == false) {
-      builder.append(false);
-    } else {
+    if (value == null) {
       throw new EncodingException("Unencodable Boolean '" + value + "'");
     }
+    builder.append(value);
   }
 
   public static boolean decode(BitString bitString) {

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/DatetimeEncoder.java

@@ -10,6 +10,7 @@
 
 public class DatetimeEncoder {
 
+  private DatetimeEncoder() {}
   public static final ZoneId UTC = ZoneId.of("UTC");
 
   public static void encode(BitStringBuilder builder, ZonedDateTime value) {

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/FibonacciIntegerEncoder.java

@@ -6,6 +6,7 @@
 import com.iab.gpp.encoder.error.EncodingException;
 
 public class FibonacciIntegerEncoder {
+  private FibonacciIntegerEncoder() {}
 
   // this is the length of the longest fibonacci encoded string of all 1's
   // which does not overflow a 32-bit integer

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/FibonacciIntegerRangeEncoder.java

@@ -6,6 +6,7 @@
 import com.iab.gpp.encoder.error.DecodingException;
 
 public class FibonacciIntegerRangeEncoder {
+  private FibonacciIntegerRangeEncoder() {}
 
   public static int encode(BitStringBuilder builder, Collection<Integer> value) {
     BitStringBuilder rangeBuilder = new BitStringBuilder();
@@ -60,7 +61,7 @@ public static IntegerSet decode(BitString bitString) throws DecodingException {
       boolean group = BooleanEncoder.decode(bitString, startIndex, 1);
       startIndex++;
 
-      if (group == true) {
+      if (group) {
         int index = FibonacciIntegerEncoder.indexOfEndTag(bitString, startIndex);
         int start = FibonacciIntegerEncoder.decode(bitString, startIndex, index + 2 - startIndex) + offset;
         offset = start;

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/FixedBitfieldEncoder.java

@@ -4,6 +4,7 @@
 import com.iab.gpp.encoder.bitstring.BitStringBuilder;
 
 public class FixedBitfieldEncoder {
+  private FixedBitfieldEncoder() {}
 
   public static void encode(BitStringBuilder builder, IntegerSet value, int bitStringLength) {
     for (int i = 0; i < bitStringLength; i++) {

iabgpp-encoder/src/main/java/com/iab/gpp/encoder/datatype/encoder/FixedIntegerEncoder.java

@@ -6,6 +6,7 @@
 import com.iab.gpp.encoder.error.EncodingException;
 
 public class FixedIntegerEncoder {
+  private FixedIntegerEncoder() {}
 
   public static void encode(BitStringBuilder builder, int value, int bitStringLength) {
     int mask = 1 << bitStringLength;