Removes prebid config for dynamic prebid backend

Author: ChristianPavilonis

crates/common/src/backend.rs

@@ -1,7 +1,8 @@
 use std::time::Duration;
 
-use error_stack::Report;
+use error_stack::{Report, ResultExt};
 use fastly::backend::Backend;
+use url::Url;
 
 use crate::error::TrustedServerError;
 
@@ -66,6 +67,21 @@ pub fn ensure_origin_backend(
         }
     }
 }
+pub fn ensure_backend_from_url(origin_url: &str) -> Result<String, Report<TrustedServerError>> {
+    let parsed_url = Url::parse(origin_url).change_context(TrustedServerError::Proxy {
+        message: format!("Invalid origin_url: {}", origin_url),
+    })?;
+
+    let scheme = parsed_url.scheme();
+    let host = parsed_url.host_str().ok_or_else(|| {
+        Report::new(TrustedServerError::Proxy {
+            message: "Missing host in origin_url".to_string(),
+        })
+    })?;
+    let port = parsed_url.port();
+
+    ensure_origin_backend(scheme, host, port)
+}
 
 #[cfg(test)]
 mod tests {

crates/common/src/prebid.rs

@@ -8,6 +8,7 @@ use fastly::http::{header, Method, StatusCode};
 use fastly::{Error, Request, Response};
 use serde_json::json;
 
+use crate::backend::ensure_backend_from_url;
 use crate::constants::{
     HEADER_SYNTHETIC_FRESH, HEADER_SYNTHETIC_TRUSTED_SERVER, HEADER_X_COMPRESS_HINT,
     HEADER_X_CONSENT_ADVERTISING, HEADER_X_FORWARDED_FOR,
@@ -194,10 +195,17 @@ impl PrebidRequest {
             id
         );
 
-        req.set_body_json(&prebid_body)?;
+        // TrustedServerError doesn't implement std::error::Error
+        match ensure_backend_from_url(&settings.prebid.server_url) {
+            Ok(backend_name) => {
+                req.set_body_json(&prebid_body)?;
 
-        let resp = req.send("prebid_backend")?;
-        Ok(resp)
+                let resp = req.send(backend_name)?;
+                Ok(resp)
+            }
+
+            Err(e) => fastly::error::bail!("Could not get prebid backend: {}", e),
+        }
     }
 }
 

crates/common/src/prebid_proxy.rs

@@ -9,6 +9,7 @@ use fastly::http::{header, Method, StatusCode};
 use fastly::{Request, Response};
 use serde_json::{json, Value};
 
+use crate::backend::ensure_backend_from_url;
 use crate::constants::{HEADER_SYNTHETIC_FRESH, HEADER_SYNTHETIC_TRUSTED_SERVER};
 use crate::error::TrustedServerError;
 use crate::gdpr::get_consent_from_request;
@@ -78,10 +79,12 @@ pub async fn handle_prebid_auction(
 
     log::info!("Sending request to Prebid Server");
 
+    let backend_name = ensure_backend_from_url(&settings.prebid.server_url)?;
+
     // 5. Send to PBS and get response
     let mut pbs_response =
         pbs_req
-            .send("prebid_backend")
+            .send(backend_name)
             .change_context(TrustedServerError::Prebid {
                 message: "Failed to send request to Prebid Server".to_string(),
             })?;
@@ -175,9 +178,12 @@ pub async fn handle_prebid_cookie_sync(
         })?;
 
     // 4. Get response and transform sync URLs
+
+    let backend_name = ensure_backend_from_url(&settings.prebid.server_url)?;
+
     let mut pbs_response =
         pbs_req
-            .send("prebid_backend")
+            .send(backend_name)
             .change_context(TrustedServerError::Prebid {
                 message: "Failed to send cookie sync request".to_string(),
             })?;

crates/common/src/publisher.rs

@@ -1,9 +1,8 @@
 use error_stack::{Report, ResultExt};
 use fastly::http::{header, StatusCode};
 use fastly::{Body, Request, Response};
-use url::Url;
 
-use crate::backend::ensure_origin_backend;
+use crate::backend::ensure_backend_from_url;
 use crate::http_util::serve_static_with_etag;
 
 use crate::constants::{
@@ -361,27 +360,15 @@ pub fn handle_publisher_request(
         has_synthetic_cookie
     );
 
-    let parsed_url =
-        Url::parse(&settings.publisher.origin_url).change_context(TrustedServerError::Proxy {
-            message: format!("Invalid origin_url: {}", settings.publisher.origin_url),
-        })?;
-
-    let scheme = parsed_url.scheme();
-    let origin_host = parsed_url.host_str().ok_or_else(|| {
-        Report::new(TrustedServerError::Proxy {
-            message: "Missing host in origin_url".to_string(),
-        })
-    })?;
-    let port = parsed_url.port();
-
-    let backend_name = ensure_origin_backend(scheme, origin_host, port)?;
+    let backend_name = ensure_backend_from_url(&settings.publisher.origin_url)?;
+    let origin_host = settings.publisher.origin_host();
 
     log::info!(
         "Proxying to dynamic backend: {} (from {})",
         backend_name,
         settings.publisher.origin_url
     );
-    req.set_header("host", origin_host);
+    req.set_header("host", &origin_host);
 
     let mut response = req
         .send(&backend_name)

fastly.toml

@@ -44,8 +44,7 @@ build = """
 
         [local_server.backends.equativ_ad_api_2]
             url = "https://adapi-srv-eu.smartadserver.com"
-        [local_server.backends.prebid_backend]
-            url = "http://68.183.113.79:8000"
+
         [local_server.backends.gam_backend]
             url = "https://securepubads.g.doubleclick.net"
         [local_server.backends.wordpress_backend]