Merge pull request #489 from IABTechLab/sch-UID2-5450-salt-rotation-alarms

sch-UID2-5450 added log line for when salt rotation is complete

Author: sophia-chen-ttd

src/main/java/com/uid2/admin/salt/SaltRotation.java

@@ -56,6 +56,7 @@ public Result rotateSalts(
 
         var postRotationSalts = rotateSalts(preRotationSalts, saltsToRotate, targetDate);
 
+        LOGGER.info("Salt rotation complete target_date={}", targetDate);
         logSaltAges("refreshable-salts", targetDate, refreshableSalts);
         logSaltAges("rotated-salts", targetDate, saltsToRotate);
         logSaltAges("total-salts", targetDate, Arrays.asList(postRotationSalts));

src/test/java/com/uid2/admin/salt/SaltRotationTest.java

@@ -365,6 +365,7 @@ void logsSaltAgesOnRotation() throws Exception {
                 .build();
 
         var expected = Set.of(
+                "[INFO] Salt rotation complete target_date=2025-01-01",
                 // Post-rotation ages, we want to look at current state
                 "[INFO] salt_count_type=total-salts target_date=2025-01-01 age=0 salt_count=2", // The two rotated salts, used to be 65 and 50 days old
                 "[INFO] salt_count_type=total-salts target_date=2025-01-01 age=5 salt_count=1",