Skip to content

Commit ec0b6fd

Browse files
committed
Adapted SDK to changes in V3 API
1 parent 162e905 commit ec0b6fd

File tree

3 files changed

+15
-39
lines changed

3 files changed

+15
-39
lines changed

src/main/java/com/uid2/client/UnmappedIdentityReason.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,15 @@
33

44
public enum UnmappedIdentityReason {
55
OPTOUT,
6-
INVALID,
6+
INVALID_IDENTIFIER,
77
UNKNOWN;
88

99
public static UnmappedIdentityReason fromString(String reason) {
10-
for (UnmappedIdentityReason knownReason : values()) {
11-
if (knownReason.name().equals(reason.toUpperCase())) {
12-
return knownReason;
13-
}
10+
if (reason.equals("optout")) {
11+
return OPTOUT;
12+
}
13+
if (reason.equals("invalid identifier")) {
14+
return INVALID_IDENTIFIER;
1415
}
1516

1617
return UNKNOWN;

src/test/java/com/uid2/client/IdentityMapV3IntegrationTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,15 +77,15 @@ public void identityMapInvalidHashedEmail() {
7777

7878
Response response = new Response(identityMapInput);
7979

80-
response.assertUnmapped(UnmappedIdentityReason.INVALID, "this is not a hashed email");
80+
response.assertUnmapped(UnmappedIdentityReason.INVALID_IDENTIFIER, "this is not a hashed email");
8181
}
8282

8383
@Test
8484
public void identityMapInvalidHashedPhone() {
8585
IdentityMapV3Input identityMapInput = IdentityMapV3Input.fromHashedPhones(Collections.singletonList("this is not a hashed phone"));
8686

8787
Response response = new Response(identityMapInput);
88-
response.assertUnmapped(UnmappedIdentityReason.INVALID, "this is not a hashed phone");
88+
response.assertUnmapped(UnmappedIdentityReason.INVALID_IDENTIFIER, "this is not a hashed phone");
8989
}
9090

9191
@Test

src/test/java/com/uid2/client/IdentityMapV3ResponseTest.java

Lines changed: 7 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -108,61 +108,36 @@ void mappedIdentity() {
108108
void unmappedIdentityReasonUnknown() {
109109
IdentityMapV3Input input = IdentityMapV3Input.fromEmails(Arrays.asList(SOME_EMAIL));
110110

111-
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("SOME_NEW_UNMAPPED_REASON"), input);
111+
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("some new unmapped reason"), input);
112112
assertTrue(response.isSuccess());
113113

114114
IdentityMapV3Response.UnmappedIdentity unmappedIdentity = response.getUnmappedIdentities().get(SOME_EMAIL);
115115
assertEquals(UnmappedIdentityReason.UNKNOWN, unmappedIdentity.getReason());
116-
assertEquals("SOME_NEW_UNMAPPED_REASON", unmappedIdentity.getRawReason());
116+
assertEquals("some new unmapped reason", unmappedIdentity.getRawReason());
117117
}
118118

119119
@Test
120120
void unmappedIdentityReasonOptout() {
121121
IdentityMapV3Input input = IdentityMapV3Input.fromEmails(Arrays.asList(SOME_EMAIL));
122122

123-
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("OPTOUT"), input);
123+
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("optout"), input);
124124
assertTrue(response.isSuccess());
125125

126126
IdentityMapV3Response.UnmappedIdentity unmappedIdentity = response.getUnmappedIdentities().get(SOME_EMAIL);
127127
assertEquals(UnmappedIdentityReason.OPTOUT, unmappedIdentity.getReason());
128-
assertEquals("OPTOUT", unmappedIdentity.getRawReason());
128+
assertEquals("optout", unmappedIdentity.getRawReason());
129129
}
130130

131131
@Test
132132
void unmappedIdentityReasonInvalid() {
133133
IdentityMapV3Input input = IdentityMapV3Input.fromEmails(Arrays.asList(SOME_EMAIL));
134134

135-
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("INVALID"), input);
135+
IdentityMapV3Response response = new IdentityMapV3Response(unmappedResponsePayload("invalid identifier"), input);
136136
assertTrue(response.isSuccess());
137137

138138
IdentityMapV3Response.UnmappedIdentity unmappedIdentity = response.getUnmappedIdentities().get(SOME_EMAIL);
139-
assertEquals(UnmappedIdentityReason.INVALID, unmappedIdentity.getReason());
140-
assertEquals("INVALID", unmappedIdentity.getRawReason());
141-
}
142-
143-
@Test
144-
void unmappedIdentityReasonCaseInsensitive() {
145-
IdentityMapV3Input input = IdentityMapV3Input.fromEmails(Arrays.asList(SOME_EMAIL));
146-
147-
IdentityMapV3Response.UnmappedIdentity lowercaseOptout =
148-
new IdentityMapV3Response(unmappedResponsePayload("optout"), input).getUnmappedIdentities().get(SOME_EMAIL);
149-
assertEquals(UnmappedIdentityReason.OPTOUT, lowercaseOptout.getReason());
150-
assertEquals("optout", lowercaseOptout.getRawReason());
151-
152-
IdentityMapV3Response.UnmappedIdentity lowercaseInvalid =
153-
new IdentityMapV3Response(unmappedResponsePayload("invalid"), input).getUnmappedIdentities().get(SOME_EMAIL);
154-
assertEquals(UnmappedIdentityReason.INVALID, lowercaseInvalid.getReason());
155-
assertEquals("invalid", lowercaseInvalid.getRawReason());
156-
157-
IdentityMapV3Response.UnmappedIdentity mixedOptout =
158-
new IdentityMapV3Response(unmappedResponsePayload("OptOut"), input).getUnmappedIdentities().get(SOME_EMAIL);
159-
assertEquals(UnmappedIdentityReason.OPTOUT, mixedOptout.getReason());
160-
assertEquals("OptOut", mixedOptout.getRawReason());
161-
162-
IdentityMapV3Response.UnmappedIdentity mixedInvalid =
163-
new IdentityMapV3Response(unmappedResponsePayload("InVaLiD"), input).getUnmappedIdentities().get(SOME_EMAIL);
164-
assertEquals(UnmappedIdentityReason.INVALID, mixedInvalid.getReason());
165-
assertEquals("InVaLiD", mixedInvalid.getRawReason());
139+
assertEquals(UnmappedIdentityReason.INVALID_IDENTIFIER, unmappedIdentity.getReason());
140+
assertEquals("invalid identifier", unmappedIdentity.getRawReason());
166141
}
167142

168143
@Test

0 commit comments

Comments
 (0)