Update the unit tests

Author: caroline-ttd

tests/test_identity_map_client.py

@@ -107,11 +107,11 @@ def test_identity_map_duplicate_hashed_emails(self):
         self.assert_unmapped(response, "optout", hashed_opted_out_email)
         self.assert_unmapped(response, "optout", duplicate_hashed_opted_out_email)
 
-    '''def test_identity_map_empty_input(self):
+    def test_identity_map_empty_input(self):
         identity_map_input = IdentityMapInput.from_emails([])
         response = self.identity_map_client.generate_identity_map(identity_map_input)
-        self.assertIsNone(response.mapped_identities)
-        self.assertIsNone(response.unmapped_identities)'''
+        self.assertTrue(len(response.mapped_identities) == 0)
+        self.assertTrue(len(response.unmapped_identities) == 0)
 
     def test_identity_map_phones(self):
         identity_map_input = IdentityMapInput.from_phones(["+12345678901", "+98765432109", "+00000000000"])

uid2_client/identity_map_input.py

@@ -9,9 +9,10 @@ class IdentityMapInput:
 
     def __init__(self, identity_type, emails_or_phones, already_hashed):
         self.hashed_dii_to_raw_diis = {}
-        self.hashed_normalized_emails = []
-        self.hashed_normalized_phones = []
+        self.hashed_normalized_emails = None
+        self.hashed_normalized_phones = None
         if identity_type == IdentityType.Email:
+            self.hashed_normalized_emails = []
             for email in emails_or_phones:
                 if already_hashed:
                     self.hashed_normalized_emails.append(email)
@@ -20,6 +21,7 @@ def __init__(self, identity_type, emails_or_phones, already_hashed):
                     self._add_hashed_to_raw_dii_mapping(hashed_normalized_email, email)
                     self.hashed_normalized_emails.append(hashed_normalized_email)
         else:  # phone
+            self.hashed_normalized_phones = []
             for phone in emails_or_phones:
                 if already_hashed:
                     self.hashed_normalized_phones.append(phone)
@@ -58,4 +60,4 @@ def get_identity_map_input_as_json_string(self):
             "email_hash": self.hashed_normalized_emails,
             "phone_hash": self.hashed_normalized_phones
         }
-        return json.dumps({k: v for k, v in json_object.items() if v is not None and len(v) > 0})
+        return json.dumps({k: v for k, v in json_object.items() if v is not None})