Skip to content

Commit eabb06d

Browse files
author
Behnam Mozafari
committed
Addressed review feedback: Operator config endpoint authentication
1 parent 2bcff62 commit eabb06d

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/main/java/com/uid2/core/vertx/CoreVerticle.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ private Router createRoutesSetup() {
199199
router.get(Endpoints.OPERATORS_REFRESH.toString()).handler(auth.handle(attestationMiddleware.handle(this::handleOperatorRefresh), Role.OPTOUT_SERVICE));
200200
router.get(Endpoints.PARTNERS_REFRESH.toString()).handler(auth.handle(attestationMiddleware.handle(this::handlePartnerRefresh), Role.OPTOUT_SERVICE));
201201
router.get(Endpoints.OPS_HEALTHCHECK.toString()).handler(this::handleHealthCheck);
202-
router.get(Endpoints.OPERATOR_CONFIG.toString()).handler(this::handleGetConfig);
202+
router.get(Endpoints.OPERATOR_CONFIG.toString()).handler(auth.handle(this::handleGetConfig, Role.OPERATOR));
203203

204204
if (Optional.ofNullable(ConfigStore.Global.getBoolean("enable_test_endpoints")).orElse(false)) {
205205
router.route(Endpoints.ATTEST_GET_TOKEN.toString()).handler(auth.handle(this::handleTestGetAttestationToken, Role.OPERATOR));

src/test/java/com/uid2/core/vertx/TestCoreVerticle.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -896,6 +896,7 @@ void keysRefreshSuccessNoHeaderVersion(Vertx vertx, VertxTestContext testContext
896896
void getConfigSuccess(Vertx vertx, VertxTestContext testContext) {
897897
JsonObject expectedConfig = new JsonObject(operatorConfig);
898898

899+
fakeAuth(Role.OPERATOR);
899900

900901
// Make HTTP Get request to operator config endpoint
901902
this.get(vertx, Endpoints.OPERATOR_CONFIG.toString(), testContext.succeeding(response -> testContext.verify(() -> {
@@ -912,6 +913,7 @@ void getConfigSuccess(Vertx vertx, VertxTestContext testContext) {
912913
void getConfigInvalidJson(Vertx vertx, VertxTestContext testContext) {
913914
operatorConfig = "invalid config";
914915

916+
fakeAuth(Role.OPERATOR);
915917

916918
this.get(vertx, Endpoints.OPERATOR_CONFIG.toString(), testContext.succeeding(response -> testContext.verify(() -> {
917919
assertEquals(500, response.statusCode());

0 commit comments

Comments
 (0)