imrpove naminig / comment

Author: Ian-Nara

src/main/java/com/uid2/optout/vertx/DeltaProductionResult.java

@@ -6,12 +6,18 @@
 public class DeltaProductionResult {
     private final int deltasProduced;
     private final int entriesProcessed;
-    private final boolean stoppedDueToRecentMessages;
 
-    public DeltaProductionResult(int deltasProduced, int entriesProcessed, boolean stoppedDueToRecentMessages) {
+    /* 
+     * indicates that there are still messages in the queue, however,
+     * not enough time has elapsed to produce a delta file.
+     * We produce in batches of (5 minutes) 
+     */
+    private final boolean stoppedDueToMessagesTooRecent;
+
+    public DeltaProductionResult(int deltasProduced, int entriesProcessed, boolean stoppedDueToMessagesTooRecent) {
         this.deltasProduced = deltasProduced;
         this.entriesProcessed = entriesProcessed;
-        this.stoppedDueToRecentMessages = stoppedDueToRecentMessages;
+        this.stoppedDueToMessagesTooRecent = stoppedDueToMessagesTooRecent;
     }
 
     public int getDeltasProduced() {
@@ -22,8 +28,8 @@ public int getEntriesProcessed() {
         return entriesProcessed;
     }
 
-    public boolean stoppedDueToRecentMessages() {
-        return stoppedDueToRecentMessages;
+    public boolean stoppedDueToMessagesTooRecent() {
+        return stoppedDueToMessagesTooRecent;
     }
 }
 

src/main/java/com/uid2/optout/vertx/OptOutSqsLogProducer.java

@@ -347,7 +347,7 @@ private JsonObject produceDeltasBlocking() throws Exception {
         DeltaProductionResult deltaResult = this.produceBatchedDeltas();
 
         // Determine status based on results
-        if (deltaResult.getDeltasProduced() == 0 && deltaResult.stoppedDueToRecentMessages()) {
+        if (deltaResult.getDeltasProduced() == 0 && deltaResult.stoppedDueToMessagesTooRecent()) {
             // No deltas produced because all messages were too recent
             result.put("status", "skipped");
             result.put("reason", "All messages too recent");
@@ -376,7 +376,7 @@ private JsonObject produceDeltasBlocking() throws Exception {
     private DeltaProductionResult produceBatchedDeltas() throws IOException {
         int deltasProduced = 0;
         int totalEntriesProcessed = 0;
-        boolean stoppedDueToRecentMessages = false;
+        boolean stoppedDueToMessagesTooRecent = false;
 
         long jobStartTime = OptOutUtils.nowEpochSeconds();
         LOGGER.info("Starting delta production from SQS queue (maxMessagesPerFile: {})", this.maxMessagesPerFile);
@@ -392,7 +392,7 @@ private DeltaProductionResult produceBatchedDeltas() throws IOException {
 
             // If no messages, we're done (queue empty or messages too recent)
             if (windowResult.isEmpty()) {
-                stoppedDueToRecentMessages = windowResult.stoppedDueToRecentMessages();
+                stoppedDueToMessagesTooRecent = windowResult.stoppedDueToMessagesTooRecent();
                 LOGGER.info("Delta production complete - no more eligible messages");
                 break;
             }
@@ -426,7 +426,7 @@ private DeltaProductionResult produceBatchedDeltas() throws IOException {
         LOGGER.info("Delta production complete: took {}s, produced {} deltas, processed {} entries",
             totalDuration, deltasProduced, totalEntriesProcessed);
 
-        return new DeltaProductionResult(deltasProduced, totalEntriesProcessed, stoppedDueToRecentMessages);
+        return new DeltaProductionResult(deltasProduced, totalEntriesProcessed, stoppedDueToMessagesTooRecent);
     }
 
     /**

src/main/java/com/uid2/optout/vertx/SqsWindowReader.java

@@ -43,19 +43,19 @@ public SqsWindowReader(SqsClient sqsClient, String queueUrl, int maxMessagesPerP
     public static class WindowReadResult {
         private final List<SqsParsedMessage> messages;
         private final long windowStart;
-        private final boolean stoppedDueToRecentMessages;
+        private final boolean stoppedDueToMessagesTooRecent;
 
         public WindowReadResult(List<SqsParsedMessage> messages, long windowStart, 
-                                boolean stoppedDueToRecentMessages) {
+                                boolean stoppedDueToMessagesTooRecent) {
             this.messages = messages;
             this.windowStart = windowStart;
-            this.stoppedDueToRecentMessages = stoppedDueToRecentMessages;
+            this.stoppedDueToMessagesTooRecent = stoppedDueToMessagesTooRecent;
         }
 
         public List<SqsParsedMessage> getMessages() { return messages; }
         public long getWindowStart() { return windowStart; }
         public boolean isEmpty() { return messages.isEmpty(); }
-        public boolean stoppedDueToRecentMessages() { return stoppedDueToRecentMessages; }
+        public boolean stoppedDueToMessagesTooRecent() { return stoppedDueToMessagesTooRecent; }
     }
 
     /**