Skip to content

Commit 0465290

Browse files
Addressing PR comments
1 parent c1a1607 commit 0465290

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/main/java/com/uid2/shared/optout/OptOutUtils.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,6 @@ public static long toLongBE(byte[] bytes, int byteIndex) {
214214
return ByteBuffer.wrap(bytes, 0, Long.BYTES).order(ByteOrder.BIG_ENDIAN).getLong();
215215
}
216216

217-
public static int compareByte(byte a, byte b) {
218-
return Byte.toUnsignedInt(a) - Byte.toUnsignedInt(b);
219-
}
220-
221217
public static boolean isDeltaFile(String fn) {
222218
return fn.contains(OptOutUtils.prefixDeltaFile);
223219
}

src/test/java/com/uid2/shared/optout/OptOutHeapTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private void checkHeapProperty(OptOutHeap heap, int i) {
126126
if (rightChild >= heap.size()) return;
127127
OptOutEntry right = heap.get(rightChild);
128128
// System.out.format("self vs right: %x %x\n", self.idHashAsLong(), right.idHashAsLong());
129-
assertTrue(Arrays.compareUnsigned(self.identityHash, left.identityHash) >0 );
129+
assertTrue(Arrays.compareUnsigned(self.identityHash, right.identityHash) >0 );
130130
checkHeapProperty(heap, rightChild);
131131
}
132132
}

0 commit comments

Comments
 (0)