Merge pull request #512 from IABTechLab/gdm-UID2-5448-cleanup

Made refreshFrom a mandatory field and removed field length check when parsing salt files

Author: gmsdelmundo

src/main/java/com/uid2/shared/store/salt/SaltFileParser.java

@@ -27,30 +27,23 @@ public SaltEntry[] parseFileLines(String[] saltFileLines, Integer size) {
 
     private SaltEntry parseLine(String line, int lineNumber) {
         try {
-            final String[] fields = line.split(",");
+            final String[] fields = line.split(",", -1);
             final long id = Integer.parseInt(fields[0]);
             final String hashedId = this.idHashingScheme.encode(id);
             final long lastUpdated = Long.parseLong(fields[1]);
             final String salt = fields[2];
+            final long refreshFrom = Long.parseLong(fields[3]);
+            final String previousSalt = trimToNull(fields[4]);
 
-            Long refreshFrom = null;
-            String previousSalt = null;
+            // TODO: The fields below should stop being optional once refreshable UIDs features get rolled out in production. We can remove them one by one as necessary.
+            // AU, 2025/07/28
             SaltEntry.KeyMaterial currentKey = null;
             SaltEntry.KeyMaterial previousKey = null;
-
-            // TODO: The fields below should stop being optional once the refresh from, previous salt
-            // and refreshable UIDs features get rolled out in production. We can remove them one by one as necessary.
-            // AU, 2025/04/28
-            if (fields.length > 3) {
-                refreshFrom = Long.parseLong(fields[3]);
-            }
-            if (fields.length > 4) {
-                previousSalt = fields[4];
-            }
-            if (fields.length > 7) {
+            if (trimToNull(fields[5]) != null && trimToNull(fields[6]) != null) {
                 currentKey = new SaltEntry.KeyMaterial(Integer.parseInt(fields[5]), fields[6], fields[7]);
             }
-            if (fields.length > 10) {
+
+            if (trimToNull(fields[8]) != null && trimToNull(fields[9]) != null) {
                 previousKey = new SaltEntry.KeyMaterial(Integer.parseInt(fields[8]), fields[9], fields[10]);
             }
 
@@ -60,4 +53,7 @@ private SaltEntry parseLine(String line, int lineNumber) {
         }
     }
 
+    private String trimToNull(String s) {
+        return s == null || s.isBlank() ? null : s.trim();
+    }
 }