Throw AttestationClientException when protocol not valid

Author: cYKatherine

src/main/java/com/uid2/shared/secure/azurecc/MaaTokenPayload.java

@@ -1,5 +1,8 @@
 package com.uid2.shared.secure.azurecc;
 
+import com.uid2.shared.secure.AttestationClientException;
+import com.uid2.shared.secure.AttestationException;
+import com.uid2.shared.secure.AttestationFailure;
 import lombok.Builder;
 import lombok.Value;
 
@@ -26,12 +29,13 @@ public boolean isSevSnpVM(){
         return SEV_SNP_VM_TYPE.equalsIgnoreCase(attestationType);
     }
 
-    public boolean isUtilityVMCompliant(){
+    public boolean isUtilityVMCompliant() throws AttestationClientException {
         if (azureProtocol == AZURE_CC_ACI_PROTOCOL) {
             return AZURE_COMPLIANT_UVM.equalsIgnoreCase(complianceStatus);
         } else if (azureProtocol == AZURE_CC_AKS_PROTOCOL) {
             return AZURE_COMPLIANT_UVM_AKS.equalsIgnoreCase(complianceStatus);
+        } else {
+            throw new AttestationClientException(String.format("Azure protocol: %s not supported", azureProtocol), AttestationFailure.INVALID_PROTOCOL);
         }
-        return false;
     }
 }

src/test/java/com/uid2/shared/secure/azurecc/PolicyValidatorTest.java

@@ -163,4 +163,16 @@ public void testValidationFailure_AksWithOtherUvm() {
         assertEquals("Not run in Azure Compliance Utility VM", t.getMessage());
         assertEquals(AttestationFailure.BAD_FORMAT, ((AttestationClientException)t).getAttestationFailure());
     }
+
+    @Test
+    public void testValidationFailure_InvalidProtocol() {
+        var validator = new PolicyValidator(ATTESTATION_URL);
+        var aksPayload = generateBasicPayload()
+                .toBuilder()
+                .azureProtocol("fake-protocol")
+                .build();
+        Throwable t = assertThrows(AttestationException.class, ()-> validator.validate(aksPayload, PUBLIC_KEY));
+        assertEquals("Azure protocol: fake-protocol not supported", t.getMessage());
+        assertEquals(AttestationFailure.INVALID_PROTOCOL, ((AttestationClientException)t).getAttestationFailure());
+    }
 }