Skip to content

Commit 05fc5aa

Browse files
authored
Merge pull request #232 from IABTechLab/sas-UID2-2793-remove-esp-and-image-actions
remove image building, rename esp
2 parents 4ce26f0 + 5930fc4 commit 05fc5aa

12 files changed

+29
-351
lines changed

.github/workflows/build-secure-signal.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: Install dependencies
4646
run: npm install
4747
- name: Build
48-
run: npm run build:esp -- --mode=${{ matrix.target }}
48+
run: npm run build:secureSignals -- --mode=${{ matrix.target }}
4949

5050
# Upload UID2 Secure Signals Files
5151
- name: Upload UID2 Secure Signals Files

.github/workflows/publish-cstg-example.yml

Lines changed: 0 additions & 38 deletions
This file was deleted.

.github/workflows/publish-js-sdk-example.yml

Lines changed: 0 additions & 38 deletions
This file was deleted.

.github/workflows/publish-secure-signal-examples.yml

Lines changed: 0 additions & 102 deletions
This file was deleted.

.github/workflows/release-secure-signal-examples-docker-image-server-only.yaml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/release-secure-signal-examples-docker-image-standard.yaml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/release-secure-signals-client-side-uid2.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

.github/workflows/release-secure-signals-react-uid2.yml

Lines changed: 0 additions & 36 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"watch": "webpack watch --mode=development",
2323
"webpack-dev-server": "webpack-dev-server --config webpack-dev-server.config.js --hot --port 9091",
2424
"uid2-examples": "webpack --mode=development --env outputToExamples=true",
25-
"build:esp": "webpack --env espOnly=true",
25+
"build:secureSignals": "webpack --env secureSignalsOnly=true",
2626
"createCA": "tsx createCA.ts",
2727
"localtest": "cd localtest && tsx server.ts"
2828
},

src/integrationTests/euidSdk.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { ProductDetails } from '../product';
1111
let callback: any;
1212
let asyncCallback: jest.Mock<CallbackHandler>;
1313
let xhrMock: any;
14-
let uid2ESP: UidSecureSignalProvider;
14+
let euidSecureSignals: UidSecureSignalProvider;
1515
let secureSignalProvidersPushMock: jest.Mock<(p: any) => Promise<void>>;
1616
let getAdvertisingTokenMock: jest.Mock<() => Promise<string>>;
1717
getAdvertisingTokenMock = jest.fn<() => Promise<string>>();
@@ -115,11 +115,11 @@ describe('when a callback is provided', () => {
115115
});
116116
});
117117

118-
describe('when getUid2AdvertisingToken exists and returns valid advertisingToken', () => {
119-
test('should send signal to Google ESP', async () => {
118+
describe('when geteuidSecureSignalsAdvertisingToken exists and returns valid advertisingToken', () => {
119+
test('should send signal to Google Secure Signals', async () => {
120120
window.getEuidAdvertisingToken = getAdvertisingTokenMock;
121121
getAdvertisingTokenMock.mockReturnValue(Promise.resolve('testToken'));
122-
uid2ESP = new UidSecureSignalProvider(false, true);
122+
euidSecureSignals = new UidSecureSignalProvider(false, true);
123123
expect(secureSignalProvidersPushMock).toHaveBeenCalledTimes(1);
124124
expect(secureSignalProvidersPushMock).toHaveBeenCalledWith(
125125
expect.objectContaining({
@@ -131,7 +131,7 @@ describe('when a callback is provided', () => {
131131
});
132132

133133
describe('When SDK initialized after both SDK and SS script loaded - EUID', () => {
134-
test('should send identity to Google ESP', async () => {
134+
test('should send identity to Google Secure Signals', async () => {
135135
__euidInternalHandleScriptLoad();
136136
__euidSSProviderScriptLoad();
137137
(sdkWindow.__euid as EUID).init({ identity });

0 commit comments

Comments
 (0)