Skip to content

Helm Chart inconsistent naming results in Services not binding to Pods #96

@DazWilkin

Description

@DazWilkin

Helm Chart inconsistently uses ibm-blockchain-network.name and ibm-blockchain-network.fullname

E.g.
CA Service selects on name == -network.name and app == -network.name
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca-service.yaml#L15

But CA Deployment name == -network.fullname (!?) and app == -network.name
https://github.com/IBM-Blockchain/ibm-container-service/blob/ff63248a583c4e548181d347d02fe3fe63b644ee/helm-charts/ibm-blockchain-network/templates/blockchain-ca.yaml#L15

This is true for all of the Deployment-Service pairs and so none of the Services binds to Pods

Recommend:
-- Use -network.name or -network.fullname consistently
-- -network.name [my preference] is simpler but could result in collisions with multiple deployments !?
-- '-network.fullname` is more long-winded but should avoid collisions
-- But are collisions likely? Wouldn't it be better to partition by namespaces anyway

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions