Update golangci to v2.7.2 (release-1.29) (#594)

Author: jckasper

.github/workflows/gatekeeper.yml

@@ -2,7 +2,7 @@ name: Gatekeeper
 
 on:
   pull_request:
-    types: [opened, synchronize, reopened]
+    types: [assigned, opened, reopened, synchronize]
   workflow_dispatch: # Allow manual triggering
 
 jobs:

.github/workflows/go.yml

@@ -38,15 +38,8 @@ jobs:
         uses: actions/setup-go@v6
         with:
           go-version: ${{ steps.get-ver.outputs.go_version }}
-      - name: Install golangci-lint v1
-        if: startsWith(steps.get-ver.outputs.golangci_version, 'v1')
-        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # SHA for v6.5.2
-        with:
-          args: --disable-all --timeout 5m # disable linting, initialize cache
-          version: ${{ steps.get-ver.outputs.golangci_version }}
       - name: Install golangci-lint v2
-        if: startsWith(steps.get-ver.outputs.golangci_version, 'v2')
-        uses: golangci/golangci-lint-action@v8
+        uses: golangci/golangci-lint-action@v9
         with:
           version: ${{ steps.get-ver.outputs.golangci_version }}
       - name: Run go fmt (via golangci-lint)

.golangci.yml

@@ -1,36 +1,32 @@
-# ******************************************************************************
-# IBM Cloud Kubernetes Service, 5737-D43
-# (C) Copyright IBM Corp. 2022, 2025 All Rights Reserved.
-#
-# SPDX-License-Identifier: Apache2.0
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-# ******************************************************************************
+version: "2"
 linters:
-  disable-all: true
   enable:
-    - gofmt
+    - gocritic
     - gosec
-    - gosimple
-    - staticcheck
-    - unused
-    - govet
+    - govet # on by default
+    - ineffassign # on by default
     - misspell
-    - ineffassign
-    - gocritic
-
-linters-settings: # please keep this alphabetized
-  staticcheck:
-    checks:
-      - "all"
-      - "-SA1006"  # TODO(fix) Using a printf-style function with a dynamic format string and no arguments can just use a print-style func
+    - staticcheck # on by default
+    - unused # on by default
+  disable:
+    - errcheck
+    - unconvert
+    - unparam
+  settings:
+    staticcheck:
+      checks:
+        - all # Enable all checks by default
+        - -ST1005 # error strings should not be capitalized / error strings should not end with punctuation or newlines
+        - -ST1017 # don't use Yoda conditions
+        - -ST1023 # should omit type string from declaration; it will be inferred from the right-hand side
+        - -QF1008 # could remove embedded field "ObjectMeta" from selector
+        - -QF1011 # could omit type string from declaration; it will be inferred from the right-hand side
+  exclusions:
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+formatters:
+  enable:
+    - gofmt

Makefile

@@ -22,7 +22,7 @@ export
 GOPACKAGES=$(shell go list ./...)
 SHFILES=$(shell find . -type f -name '*.sh')
 
-GOLANGCI_LINT_VERSION := 1.64.8
+GOLANGCI_LINT_VERSION := 2.7.2
 GOLANGCI_LINT_EXISTS := $(shell golangci-lint --version 2>/dev/null)
 
 TAG ?= v1.29.15
@@ -33,7 +33,7 @@ all: fmt lint lint-sh vet test ccm
 .PHONY: fmt
 fmt:
 ifdef GOLANGCI_LINT_EXISTS
-	golangci-lint run --disable-all --no-config --enable=gofmt --timeout 5m
+	golangci-lint fmt -v
 else
 	@echo "golangci-lint is not installed"
 	exit 1