feat: increase token expiration check visibility (#424)

Author: steveclay

bluemix/configuration/core_config/bx_config.go

@@ -313,18 +313,18 @@ func (c *bxConfig) IAMID() (guid string) {
 func (c *bxConfig) IsLoggedIn() bool {
 	if token, refresh := c.IAMToken(), c.IAMRefreshToken(); token != "" || refresh != "" {
 		iamTokenInfo := NewIAMTokenInfo(token)
-		if iamTokenInfo.hasExpired() && refresh != "" {
+		if iamTokenInfo.HasExpired() && refresh != "" {
 			repo := newRepository(c)
 			if _, err := repo.RefreshIAMToken(); err != nil {
 				return false
 			}
 			// Check again to make sure that the new token has not expired
-			if iamTokenInfo = NewIAMTokenInfo(c.IAMToken()); iamTokenInfo.hasExpired() {
+			if iamTokenInfo = NewIAMTokenInfo(c.IAMToken()); iamTokenInfo.HasExpired() {
 				return false
 			}
 
 			return true
-		} else if iamTokenInfo.hasExpired() && refresh == "" {
+		} else if iamTokenInfo.HasExpired() && refresh == "" {
 			return false
 		} else {
 			return true

bluemix/configuration/core_config/iam_token.go

@@ -93,7 +93,7 @@ func (t IAMTokenInfo) exists() bool {
 	return t.ID != ""
 }
 
-func (t IAMTokenInfo) hasExpired() bool {
+func (t IAMTokenInfo) HasExpired() bool {
 	if !t.exists() {
 		return true
 	}

bluemix/configuration/core_config/iam_token_test.go

@@ -98,7 +98,7 @@ func TestIAMTokenHasExpired(t *testing.T) {
 	for _, testCase := range TestIAMTokenHasExpiredTestCases {
 		t.Run(testCase.name, func(t *testing.T) {
 			tokenInfo := NewIAMTokenInfo(testCase.token)
-			assert.Equal(t, testCase.isExpired, tokenInfo.hasExpired())
+			assert.Equal(t, testCase.isExpired, tokenInfo.HasExpired())
 		})
 	}
 }