fix: removed unused error return

Author: Aerex

bluemix/configuration/core_config/bx_config.go

@@ -771,10 +771,7 @@ func (c *bxConfig) ClearPaginationURLs() {
 }
 
 func (c *bxConfig) AddPaginationURL(index int, url string) error {
-	urls, err := c.PaginationURLs()
-	if err != nil {
-		return err
-	}
+	urls := c.PaginationURLs()
 
 	urls = append(urls, models.PaginationURL{
 		LastIndex: index,
@@ -787,7 +784,7 @@ func (c *bxConfig) AddPaginationURL(index int, url string) error {
 	return nil
 }
 
-func (c *bxConfig) PaginationURLs() (paginationURLs []models.PaginationURL, err error) {
+func (c *bxConfig) PaginationURLs() (paginationURLs []models.PaginationURL) {
 	c.read(func() {
 		paginationURLs = c.data.PaginationURLs
 	})

bluemix/configuration/core_config/bx_config_test.go

@@ -473,8 +473,7 @@ func TestPaginationURLs(t *testing.T) {
 	config := prepareConfigForCLI(`{}`, t)
 
 	// check initial state
-	paginationURLs, err := config.PaginationURLs()
-	assert.Nil(t, err)
+	paginationURLs := config.PaginationURLs()
 	assert.Empty(t, paginationURLs)
 
 	// update session
@@ -485,10 +484,8 @@ func TestPaginationURLs(t *testing.T) {
 		},
 	}
 	config.SetPaginationURLs(expected)
-	assert.Nil(t, err)
 
-	paginationURLs, err = config.PaginationURLs()
-	assert.Nil(t, err)
+	paginationURLs = config.PaginationURLs()
 	assert.Equal(t, 1, len(paginationURLs))
 	assert.Equal(t, expected[0].LastIndex, paginationURLs[0].LastIndex)
 	assert.Equal(t, expected[0].NextURL, paginationURLs[0].NextURL)

bluemix/configuration/core_config/repository.go

@@ -129,7 +129,7 @@ type Repository interface {
 	SetPaginationURLs(paginationURLs []models.PaginationURL)
 	ClearPaginationURLs()
 	AddPaginationURL(lastIndex int, nextURL string) error
-	PaginationURLs() ([]models.PaginationURL, error)
+	PaginationURLs() []models.PaginationURL
 }
 
 // Deprecated
@@ -373,7 +373,7 @@ func (c repository) SetLastSessionUpdateTime() {
 	c.bxConfig.SetLastSessionUpdateTime()
 }
 
-func (c repository) PaginationURLs() ([]models.PaginationURL, error) {
+func (c repository) PaginationURLs() []models.PaginationURL {
 	return c.bxConfig.PaginationURLs()
 }
 

common/rest/request_test.go

@@ -201,8 +201,7 @@ func TestAddPaginationURL(t *testing.T) {
 	}
 
 	// expect url to be sorted in ascending order by LastIndex
-	sortedUrls, err := config.PaginationURLs()
-	assert.Nil(err)
+	sortedUrls := config.PaginationURLs()
 
 	assert.Equal(2, len(sortedUrls))
 	assert.Equal(sortedUrls[0].LastIndex, unsortedUrls[1].LastIndex)