[Datasource] Sap profile filtering (#6324)

Co-authored-by: Alexander Kita <[email protected]>

Author: ismirlia

ibm/service/power/data_source_ibm_pi_sap_profiles.go

@@ -26,6 +26,18 @@ func DataSourceIBMPISAPProfiles() *schema.Resource {
 				Type:         schema.TypeString,
 				ValidateFunc: validation.NoZeroValues,
 			},
+			Arg_FamilyFilter: {
+				Description:  "SAP profile family filter.",
+				Optional:     true,
+				Type:         schema.TypeString,
+				ValidateFunc: validation.StringInSlice([]string{"balanced", "compute", "memory", "sap-rise", "sap-rise-app", "small", "ultra-memory"}, false),
+			},
+			Arg_PrefixFilter: {
+				Description:  "SAP profile prefix filter.",
+				Optional:     true,
+				Type:         schema.TypeString,
+				ValidateFunc: validation.StringInSlice([]string{"bh1", "bh2", "ch1", "ch2", "mh1", "mh2", "umh", "ush1", "sh2", "sr2"}, false),
+			},
 
 			// Attributes
 			Attr_Profiles: {
@@ -106,7 +118,15 @@ func dataSourceIBMPISAPProfilesRead(ctx context.Context, d *schema.ResourceData,
 	cloudInstanceID := d.Get(Arg_CloudInstanceID).(string)
 
 	client := instance.NewIBMPISAPInstanceClient(ctx, sess, cloudInstanceID)
-	sapProfiles, err := client.GetAllSAPProfiles(cloudInstanceID)
+	filters := map[string]string{}
+	if v, ok := d.GetOk(Arg_FamilyFilter); ok {
+		filters[Arg_FamilyFilter] = v.(string)
+	}
+	if v, ok := d.GetOk(Arg_PrefixFilter); ok {
+		filters[Arg_PrefixFilter] = v.(string)
+	}
+
+	sapProfiles, err := client.GetAllSAPProfilesWithFilters(cloudInstanceID, filters)
 	if err != nil {
 		log.Printf("[DEBUG] get all sap profiles failed %v", err)
 		return diag.FromErr(err)

ibm/service/power/data_source_ibm_pi_sap_profiles_test.go

@@ -33,3 +33,27 @@ func testAccCheckIBMPISAPProfilesDataSourceConfig() string {
 			pi_cloud_instance_id = "%s"
 		}`, acc.Pi_cloud_instance_id)
 }
+
+func TestAccIBMPISAPProfilesDataSourceFilters(t *testing.T) {
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { acc.TestAccPreCheck(t) },
+		Providers: acc.TestAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccCheckIBMPISAPProfilesDataSourceFiltersConfig(),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttrSet("data.ibm_pi_sap_profiles.test", "id"),
+				),
+			},
+		},
+	})
+}
+
+func testAccCheckIBMPISAPProfilesDataSourceFiltersConfig() string {
+	return fmt.Sprintf(`
+		data "ibm_pi_sap_profiles" "test" {
+			pi_cloud_instance_id = "%s"
+			pi_family_filter     = "balanced"
+			pi_prefix_filter     = "bh1"
+		}`, acc.Pi_cloud_instance_id)
+}

ibm/service/power/ibm_pi_constants.go

@@ -49,6 +49,7 @@ const (
 	Arg_DNS                                  = "pi_dns"
 	Arg_DnsServer                            = "pi_dns_server"
 	Arg_EndingIPAddress                      = "pi_ending_ip_address"
+	Arg_FamilyFilter                         = "pi_family_filter"
 	Arg_Gateway                              = "pi_gateway"
 	Arg_HealthStatus                         = "pi_health_status"
 	Arg_Host                                 = "pi_host"
@@ -100,6 +101,7 @@ const (
 	Arg_PlacementGroupName                   = "pi_placement_group_name"
 	Arg_PlacementGroupPolicy                 = "pi_placement_group_policy"
 	Arg_Plan                                 = "pi_plan"
+	Arg_PrefixFilter                         = "pi_prefix_filter"
 	Arg_Processors                           = "pi_processors"
 	Arg_ProcType                             = "pi_proc_type"
 	Arg_Protocol                             = "pi_protocol"

website/docs/d/pi_sap_profiles.html.markdown

@@ -39,6 +39,8 @@ Example usage:
 Review the argument references that you can specify for your data source.
 
 - `pi_cloud_instance_id` - (Required, String) The GUID of the service instance associated with an account.
+- `pi_family_filter` - (Optional, String) SAP profile family filter. Allowed values are: ["balanced", "compute", "memory", "sap-rise", "sap-rise-app", "small", "ultra-memory"].
+- `pi_prefix_filter` - (Optional, String) SAP profile prefix filter. Allowed values are: ["bh1", "bh2", "ch1", "ch2", "mh1", "mh2", "umh", "ush1", "sh2", "sr2"].
 
 ## Attribute Reference